Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1054993002: Streamline Thumb config. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Streamline Thumb config. Enable Thumb2 iff ARM v7. (We don't turn it on today for ARM <v7, and ARM v8 doesn't support it.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/2d33a1d0b03dc7cb171c6f34680f1966fa686d38

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Merge branch 'daisy' into thumb Conflicts: platform_tools/chromeos/bin/chromeos_setup.sh #

Patch Set 4 : base on daisy #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -19 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 chunk +3 lines, -3 lines 0 comments Download
M platform_tools/android/gyp_gen/android_framework_gyp.py View 1 chunk +2 lines, -2 lines 0 comments Download
M platform_tools/chromeos/bin/chromeos_setup.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein_C
5 years, 8 months ago (2015-04-02 17:02:04 UTC) #2
djsollen
lgtm
5 years, 8 months ago (2015-04-02 17:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054993002/80001
5 years, 8 months ago (2015-04-02 17:42:03 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 17:48:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2d33a1d0b03dc7cb171c6f34680f1966fa686d38

Powered by Google App Engine
This is Rietveld 408576698