platform_tools/android/gyp_gen/android_framework_gyp.py - Issue 1054993002: Streamline Thumb config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/gyp_gen/android_framework_gyp.py

Issue 1054993002: Streamline Thumb config. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/gyp_gen/android_framework_gyp.py

diff --git a/platform_tools/android/gyp_gen/android_framework_gyp.py b/platform_tools/android/gyp_gen/android_framework_gyp.py

index 787a4d91a8cceaf1b7705ab62d3ce898614c7444..34a9eeec4796068e90cc2e6835324f86b0a80482 100644

--- a/platform_tools/android/gyp_gen/android_framework_gyp.py

+++ b/platform_tools/android/gyp_gen/android_framework_gyp.py

@@ -63,8 +63,8 @@ def main(target_dir, target_file, skia_arch_type, have_neon,

gyp_defines = ('skia_android_framework=1 OS=android skia_arch_type=%s '

% skia_arch_type)

if skia_arch_type == 'arm':

- # Always use thumb and version 7 for arm

- gyp_defines += 'arm_thumb=1 arm_version=7 '

+ # Always version 7 (which implies thumb) for arm

+ gyp_defines += 'arm_version=7 '

if have_neon:

gyp_defines += 'arm_neon=1 '

else: