Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Unified Diff: gyp/common_conditions.gypi

Issue 1054993002: Streamline Thumb config. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 7f0b6021ddcc1265609a380c89d19c7255984451..5f99eae34077f2fc3b90c751eaa3f997b8aa1fcb 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -265,28 +265,10 @@
'-fno-omit-frame-pointer',
],
}],
- [ 'skia_arch_type == "arm" and arm_thumb == 1', {
- 'cflags': [
- '-mthumb',
- ],
- # The --fix-cortex-a8 switch enables a link-time workaround for
- # an erratum in certain Cortex-A8 processors. The workaround is
- # enabled by default if you target the ARM v7-A arch profile.
- # It can be enabled otherwise by specifying --fix-cortex-a8, or
- # disabled unconditionally by specifying --no-fix-cortex-a8.
- #
- # The erratum only affects Thumb-2 code.
- 'conditions': [
- [ 'arm_version < 7', {
- 'ldflags': [
- '-Wl,--fix-cortex-a8',
- ],
- }],
- ],
- }],
[ 'skia_arch_type == "arm" and arm_version >= 7', {
'cflags': [
'-march=armv7-a',
+ '-mthumb',
],
'ldflags': [
'-march=armv7-a',
« no previous file with comments | « no previous file | platform_tools/android/bin/android_setup.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698