Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1054883004: Revert of Use the desktop GL core profile on Linux when ES3 support is requested. (Closed)

Created:
5 years, 8 months ago by marcheu
Modified:
5 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, no sievers, bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use the desktop GL core profile on Linux when ES3 support is requested. (patchset #3 id:40001 of https://codereview.chromium.org/1052153002/) Reason for revert: This causes Chrome rendering to break on some Chrome OS devices, see crbug.com/473891 for details Original issue's description: > Use the desktop GL core profile on Linux when ES3 support is requested. > > Request an OpenGL 4.2 context (the minimum version Chromium's WebGL > 2.0 prototype currently requires) on Linux when > --enable-unsafe-es3-apis is specified on the command line. > > Clean up the shader translator's selection of the GLSL output format. > > BUG=471960 > > Committed: https://crrev.com/0b17446f9591af9377d18c9ccfe50471651d6bc7 > Cr-Commit-Position: refs/heads/master@{#323658} TBR=piman@chromium.org,kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471960 Committed: https://crrev.com/1856f5d5e47d72742a12153f4e85ee0db00c11a0 Cr-Commit-Position: refs/heads/master@{#323866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -65 lines) Patch
M gpu/command_buffer/service/async_pixel_transfer_manager_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 13 chunks +13 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/gl/gl_context_x11.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/gl_implementation_x11.cc View 5 chunks +3 lines, -10 lines 0 comments Download
M ui/gl/gl_surface_x11.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marcheu
Created Revert of Use the desktop GL core profile on Linux when ES3 support is ...
5 years, 8 months ago (2015-04-04 01:41:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054883004/1
5 years, 8 months ago (2015-04-04 01:41:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-04 01:43:09 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 01:43:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1856f5d5e47d72742a12153f4e85ee0db00c11a0
Cr-Commit-Position: refs/heads/master@{#323866}

Powered by Google App Engine
This is Rietveld 408576698