chrome/common/extensions/manifest_handlers/externally_connectable.h - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/externally_connectable.h

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/content_scripts_handler.cc ('k') | chrome/common/extensions/manifest_handlers/externally_connectable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/externally_connectable.h

diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable.h b/chrome/common/extensions/manifest_handlers/externally_connectable.h

index 681da8ba67a77c7285594e4ead25f5ae948d87fb..db4b97abecaec2c6dcc948f5b11e710abde77abf 100644

--- a/chrome/common/extensions/manifest_handlers/externally_connectable.h

+++ b/chrome/common/extensions/manifest_handlers/externally_connectable.h

@@ -38,7 +38,7 @@ class ExternallyConnectableHandler : public ManifestHandler {

ExternallyConnectableHandler();

virtual ~ExternallyConnectableHandler();

- virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;

private:

virtual const std::vector<std::string> Keys() const OVERRIDE;

@@ -58,7 +58,7 @@ struct ExternallyConnectableInfo : public Extension::ManifestData {

static scoped_ptr<ExternallyConnectableInfo> FromValue(

const base::Value& value,

std::vector<InstallWarning>* install_warnings,

- string16* error);

+ base::string16* error);

virtual ~ExternallyConnectableInfo();