chrome/common/extensions/manifest_handlers/externally_connectable.cc - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/externally_connectable.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/externally_connectable.h ('k') | chrome/common/extensions/manifest_handlers/icons_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/externally_connectable.cc

diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable.cc b/chrome/common/extensions/manifest_handlers/externally_connectable.cc

index 7be1d2391788a3873e32cd57aa055759159bc48f..cacb13ae1f8eb180c0d0261793e633282cd63055 100644

--- a/chrome/common/extensions/manifest_handlers/externally_connectable.cc

+++ b/chrome/common/extensions/manifest_handlers/externally_connectable.cc

@@ -56,7 +56,7 @@ ExternallyConnectableHandler::ExternallyConnectableHandler() {}

ExternallyConnectableHandler::~ExternallyConnectableHandler() {}

bool ExternallyConnectableHandler::Parse(Extension* extension,

- string16* error) {

+ base::string16* error) {

const base::Value* externally_connectable = NULL;

CHECK(extension->manifest()->Get(keys::kExternallyConnectable,

&externally_connectable));

@@ -91,7 +91,7 @@ ExternallyConnectableInfo* ExternallyConnectableInfo::Get(

scoped_ptr<ExternallyConnectableInfo> ExternallyConnectableInfo::FromValue(

const base::Value& value,

std::vector<InstallWarning>* install_warnings,

- string16* error) {

+ base::string16* error) {

scoped_ptr<ExternallyConnectable> externally_connectable =

ExternallyConnectable::FromValue(value, error);

if (!externally_connectable)