Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/content_scripts_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc b/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc
index 6e48e8203f74faed9795732fffae6c41804ac5c6..32d42f9d01e606b4d8e1c3408a028149162717c5 100644
--- a/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc
@@ -36,7 +36,7 @@ namespace {
bool LoadGlobsHelper(const base::DictionaryValue* content_script,
int content_script_index,
const char* globs_property_name,
- string16* error,
+ base::string16* error,
void(UserScript::*add_method)(const std::string& glob),
UserScript* instance) {
if (!content_script->HasKey(globs_property_name))
@@ -73,7 +73,7 @@ bool LoadGlobsHelper(const base::DictionaryValue* content_script,
bool LoadUserScriptFromDictionary(const base::DictionaryValue* content_script,
int definition_index,
Extension* extension,
- string16* error,
+ base::string16* error,
UserScript* result) {
// run_at
if (content_script->HasKey(keys::kRunAt)) {
@@ -380,7 +380,7 @@ const std::vector<std::string> ContentScriptsHandler::Keys() const {
return std::vector<std::string>(keys, keys + arraysize(keys));
}
-bool ContentScriptsHandler::Parse(Extension* extension, string16* error) {
+bool ContentScriptsHandler::Parse(Extension* extension, base::string16* error) {
scoped_ptr<ContentScriptsInfo> content_scripts_info(new ContentScriptsInfo);
const base::ListValue* scripts_list = NULL;
if (!extension->manifest()->GetList(keys::kContentScripts, &scripts_list)) {

Powered by Google App Engine
This is Rietveld 408576698