Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1054683003: upload.py will soon have dry run flags, read and use them in Rietveld (Closed)

Created:
5 years, 8 months ago by rmistry
Modified:
5 years, 8 months ago
Reviewers:
jrobbins
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

upload.py will soon have dry run flags, read and use them in Rietveld The corresponding depot_tools change is here: https://codereview.chromium.org/1053653004/ BUG=chromium:472690 NOTRY=true Committed: https://chromium.googlesource.com/infra/infra/+/76f59722a178e1243e630c532fe83cc4713e124b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M appengine/chromium_rietveld/codereview/views.py View 4 chunks +7 lines, -0 lines 0 comments Download
M appengine/chromium_rietveld/upload.py View 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
rmistry
https://codereview.chromium.org/1054683003/diff/1/appengine/chromium_rietveld/upload.py File appengine/chromium_rietveld/upload.py (right): https://codereview.chromium.org/1054683003/diff/1/appengine/chromium_rietveld/upload.py#newcode1 appengine/chromium_rietveld/upload.py:1: #!/usr/bin/env python The changes in this file are identical ...
5 years, 8 months ago (2015-04-01 18:48:55 UTC) #2
jrobbins
lgtm
5 years, 8 months ago (2015-04-01 23:09:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054683003/1
5 years, 8 months ago (2015-04-02 11:38:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054683003/1
5 years, 8 months ago (2015-04-02 11:43:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054683003/1
5 years, 8 months ago (2015-04-02 11:47:57 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 11:48:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/76f59722a178e1243e630c532fe83...

Powered by Google App Engine
This is Rietveld 408576698