Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: appengine/chromium_rietveld/codereview/views.py

Issue 1054683003: upload.py will soon have dry run flags, read and use them in Rietveld (Closed) Base URL: https://chromium.googlesource.com/infra/infra@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/chromium_rietveld/upload.py » ('j') | appengine/chromium_rietveld/upload.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_rietveld/codereview/views.py
diff --git a/appengine/chromium_rietveld/codereview/views.py b/appengine/chromium_rietveld/codereview/views.py
index 13f077c2810cc05873f224deb405d8081b8a8027..74a44dcebc6e0c54db59247ac648dd3eb28eaefe 100644
--- a/appengine/chromium_rietveld/codereview/views.py
+++ b/appengine/chromium_rietveld/codereview/views.py
@@ -175,6 +175,7 @@ class UploadForm(forms.Form):
separate_patches = forms.BooleanField(required=False)
base = forms.CharField(max_length=MAX_URL, required=False)
target_ref = forms.CharField(max_length=MAX_URL, required=False)
+ cq_dry_run = forms.BooleanField(required=False)
data = forms.FileField(required=False)
issue = forms.IntegerField(required=False)
reviewers = forms.CharField(max_length=MAX_REVIEWERS, required=False)
@@ -1427,6 +1428,8 @@ def _make_new(request, form):
project = form.cleaned_data['project']
target_ref = _get_target_ref(form, issue_key, project)
+ cq_dry_run = form.cleaned_data.get('cq_dry_run', False)
+ cq_dry_run_triggered_by = account.email if cq_dry_run else ''
issue = models.Issue(subject=form.cleaned_data['subject'],
description=form.cleaned_data['description'],
@@ -1439,6 +1442,8 @@ def _make_new(request, form):
cc=cc,
private=form.cleaned_data.get('private', False),
n_comments=0,
+ cq_dry_run=cq_dry_run,
+ cq_dry_run_last_triggered_by=cq_dry_run_triggered_by,
key=issue_key)
issue.put()
@@ -1573,6 +1578,8 @@ def _add_patchset_from_form(request, issue, form, message_key='message',
issue.cc, _ = _get_emails(form, 'cc')
issue.commit = False
issue.target_ref = _get_target_ref(form, issue.key, issue.project)
+ issue.cq_dry_run = form.cleaned_data.get('cq_dry_run', False)
+ issue.cq_dry_run_last_triggered_by = account.email if issue.cq_dry_run else ''
issue.calculate_updates_for()
# New patchset has been uploaded, add to the approvers_to_notify list.
approval_dict = json.loads(issue.reviewer_approval)
« no previous file with comments | « no previous file | appengine/chromium_rietveld/upload.py » ('j') | appengine/chromium_rietveld/upload.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698