Implement support for notification.vibrate

content/child/notifications/notification_data_conversions_unittest.cc

Index: content/child/notifications/notification_data_conversions_unittest.cc
diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc
index daded25dfd5f8eede6b29226cf70e7eb170b7e02..15d531808e291b378ace5eaa854998cd1f71318e 100644
--- a/content/child/notifications/notification_data_conversions_unittest.cc
+++ b/content/child/notifications/notification_data_conversions_unittest.cc
@@ -20,9 +20,14 @@ const char kNotificationLang[] = "nl";
 const char kNotificationBody[] = "Hello, world!";
 const char kNotificationTag[] = "my_tag";
 const char kNotificationIconUrl[] = "https://example.com/icon.png";
+const unsigned kNotificationVibrate[] = { 100, 200, 300 };
 const unsigned char kNotificationData[] = { 0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf };
 
 TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
+  std::vector<unsigned> vibrate_pattern(

[Peter Beverloo, 2015/04/21 17:58:23]

dito re: types in this file.

[Sanghyun Park, 2015/04/23 11:08:26]

Done.

+      kNotificationVibrate,
+      kNotificationVibrate + arraysize(kNotificationVibrate));
+
   std::vector<char> developer_data(
       kNotificationData, kNotificationData + arraysize(kNotificationData));
 
@@ -33,6 +38,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
       blink::WebString::fromUTF8(kNotificationBody),
       blink::WebString::fromUTF8(kNotificationTag),
       blink::WebURL(GURL(kNotificationIconUrl)),
+      blink::WebVector<unsigned>(vibrate_pattern),
       true /* silent */,
       blink::WebVector<char>(developer_data));
 
@@ -46,6 +52,10 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
   EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
   EXPECT_TRUE(platform_data.silent);
 
+  ASSERT_EQ(vibrate_pattern.size(), platform_data.vibrate.size());
+  for (size_t i = 0; i < vibrate_pattern.size(); ++i)
+    EXPECT_EQ(vibrate_pattern[i], platform_data.vibrate[i]);
+
   ASSERT_EQ(developer_data.size(), platform_data.data.size());
   for (size_t i = 0; i < developer_data.size(); ++i)
     EXPECT_EQ(developer_data[i], platform_data.data[i]);
@@ -68,6 +78,10 @@ TEST(NotificationDataConversionsTest,
 }
 
 TEST(NotificationDataConversionsTest, ToWebNotificationData) {
+  std::vector<unsigned> vibrate_pattern(
+      kNotificationVibrate,
+      kNotificationVibrate + arraysize(kNotificationVibrate));
+
   std::vector<char> developer_data(
       kNotificationData, kNotificationData + arraysize(kNotificationData));
 
@@ -79,6 +93,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
   platform_data.body = base::ASCIIToUTF16(kNotificationBody);
   platform_data.tag = kNotificationTag;
   platform_data.icon = GURL(kNotificationIconUrl);
+  platform_data.vibrate = vibrate_pattern;
   platform_data.silent = true;
   platform_data.data = developer_data;
 
@@ -90,6 +105,11 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
   EXPECT_EQ(kNotificationBody, web_data.body);
   EXPECT_EQ(kNotificationTag, web_data.tag);
   EXPECT_EQ(kNotificationIconUrl, web_data.icon.string());
+
+  ASSERT_EQ(vibrate_pattern.size(), web_data.vibrate.size());
+  for (size_t i = 0; i < vibrate_pattern.size(); ++i)
+    EXPECT_EQ(vibrate_pattern[i], web_data.vibrate[i]);
+
   EXPECT_TRUE(web_data.silent);
 
   ASSERT_EQ(developer_data.size(), web_data.data.size());