Implement support for notification.vibrate

content/public/common/platform_notification_data.h

Index: content/public/common/platform_notification_data.h
diff --git a/content/public/common/platform_notification_data.h b/content/public/common/platform_notification_data.h
index 5b608c0d3b2b5d668b2978a1461743be45e3b39c..ac6b34fdec3b9aa7a1cdad1f3d81f8c4f4fc286a 100644
--- a/content/public/common/platform_notification_data.h
+++ b/content/public/common/platform_notification_data.h
@@ -51,6 +51,9 @@ struct CONTENT_EXPORT PlatformNotificationData {
   // URL of the icon which is to be displayed with the notification.
   GURL icon;
 
+  // Vibrate pettern for notification.

[Avi (use Gerrit), 2015/04/21 17:28:47]

typo: pattern

[Peter Beverloo, 2015/04/21 17:58:23]

I'd prefer the following comment:

  // Vibration pattern for the notification, following the syntax of the
  // Vibration API. https://www.w3.org/TR/vibration/

[Sanghyun Park, 2015/04/23 11:08:27]

Done.

[Sanghyun Park, 2015/04/23 11:08:27]

Done.

+  std::vector<unsigned> vibrate;

[Avi (use Gerrit), 2015/04/21 17:28:47]

Use of unsigned ints is prohibited by the style guide. Use int.

https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types

[Peter Beverloo, 2015/04/21 17:58:23]

We clamp the individual vibration indices to [0, blink::kVibrationDurationMax]
in Blink, which currently matches [0, 10000]. Using std::vector<int> here seems
good to me, but please change this consistently throughout the CL.

[Sanghyun Park, 2015/04/23 11:08:27]

Thanks for letting me know .
I didn't know about [1].
We'll refer [1]document in detail.

[1]
"https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types".

+
   // Whether default notification indicators (sound, vibration, light) should
   // be suppressed.
   bool silent = false;