chrome/browser/ui/webui/signin/inline_login_ui.cc - Issue 1054403002: Basic tests for new webview based signin flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui.cc

Issue 1054403002: Basic tests for new webview based signin flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove flaky back-button check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/inline_login_ui.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_ui.cc b/chrome/browser/ui/webui/signin/inline_login_ui.cc

index d45b25e3cfbafd521b962770a97c953c6403b5bf..6bd7c52b1a036b6bf0d47b0dc56913868b109183 100644

--- a/chrome/browser/ui/webui/signin/inline_login_ui.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_ui.cc

@@ -127,7 +127,7 @@ InlineLoginUI::InlineLoginUI(content::WebUI* web_ui)

InlineLoginUI::~InlineLoginUI() {}

// Gets the Gaia iframe within a WebContents.

-content::RenderFrameHost* InlineLoginUI::GetAuthIframe(

+content::RenderFrameHost* InlineLoginUI::GetAuthFrame(

content::WebContents* web_contents,

const GURL& parent_origin,

const std::string& parent_frame_name) {