chrome/browser/ui/webui/signin/login_ui_test_utils.cc - Issue 1054403002: Basic tests for new webview based signin flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/login_ui_test_utils.cc

Issue 1054403002: Basic tests for new webview based signin flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove flaky back-button check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/login_ui_test_utils.cc

diff --git a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc b/chrome/browser/ui/webui/signin/login_ui_test_utils.cc

index 376bd4b25bdab8b62e8ed92b0c39c7a19982c7ba..7f5e2bfd5c25cbe19b176f0b25d2fffd74b77dd6 100644

--- a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc

+++ b/chrome/browser/ui/webui/signin/login_ui_test_utils.cc

@@ -114,7 +114,7 @@ void ExecuteJsToSigninInSigninFrame(Browser* browser,

content::WebContents* web_contents =

browser->tab_strip_model()->GetActiveWebContents();

- ASSERT_TRUE(content::ExecuteScript(InlineLoginUI::GetAuthIframe(

+ ASSERT_TRUE(content::ExecuteScript(InlineLoginUI::GetAuthFrame(

web_contents, GURL(), "signin-frame"), js));

}

« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_ui.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »