chrome/browser/ui/webui/signin/inline_login_ui.h - Issue 1054403002: Basic tests for new webview based signin flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui.h

Issue 1054403002: Basic tests for new webview based signin flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove flaky back-button check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/inline_login_ui.h

diff --git a/chrome/browser/ui/webui/signin/inline_login_ui.h b/chrome/browser/ui/webui/signin/inline_login_ui.h

index d4c4408253d8712a68d4ad853c9521d81f324f4a..20a9f23f75fc180a9268c2a67df7fd9857f33faa 100644

--- a/chrome/browser/ui/webui/signin/inline_login_ui.h

+++ b/chrome/browser/ui/webui/signin/inline_login_ui.h

@@ -21,9 +21,10 @@ class InlineLoginUI : public ui::WebDialogUI {

explicit InlineLoginUI(content::WebUI* web_ui);

~InlineLoginUI() override;

- // Gets the iframe within an auth page that has the specified parent origin

- // if |parent_origin| is not empty, and the specified parent frame name.

- static content::RenderFrameHost* GetAuthIframe(

+ // Gets the frame (iframe or webview) within an auth page that has the

+ // specified parent origin if |parent_origin| is not empty, and the specified

+ // parent frame name.

+ static content::RenderFrameHost* GetAuthFrame(

content::WebContents* web_contents,

const GURL& parent_origin,

const std::string& parent_frame_name);