Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1054233002:
Try ARMv7 and NEON for Daisy. (Closed)
DescriptionTry ARMv7 and NEON for Daisy.
I think Daisy's color order problems are in non-NEON ARM assembly.
NEON might actually be fine.
BUG=skia:1843
Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android_Neon-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot,Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot
Committed: https://skia.googlesource.com/skia/+/ac813d8a1212bf31c75a564a57fe5240edb84019
Patch Set 1 #Patch Set 2 : Use vget_lane for older compiler compatibility. #Patch Set 3 : compile-time constants #Patch Set 4 : fixed #Patch Set 5 : so... close... #Patch Set 6 : rebase #Messages
Total messages: 39 (22 generated)
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as a121c0ee6b911dd7004c6054a8692d37084b6b3d (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1058173002/ by mtklein@google.com. The reason for reverting is: whatever compiler we're using can't handle array subscripts for neon vectors.
mtklein@google.com changed reviewers: + mtklein@google.com
The CQ bit was checked by mtklein@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1054233002/#ps40001 (title: "compile-time constants")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1054233002/#ps60001 (title: "fixed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/60001
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com to run a CQ dry run
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1054233002/#ps80001 (title: "so... close...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/80001
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1054233002/#ps100001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/100001
The CQ bit was unchecked by commit-bot@chromium.org
This issue passed the CQ dry run.
mtklein@chromium.org changed reviewers: + scroggo@google.com
+Leon, can you make sure I've got my libpng logic right? I believe Android always goes down the non-static path here today, so disabling NEON in the static libpng doesn't affect Android. Should be that as of this change, we go from having 0 non-Android NEON devices to 1, Daisy. So this setting really only affects Daisy. I'm leaving it TBD to figure out how to compile the libpng NEON code and turn it back on.
scroggo@google.com changed reviewers: + djsollen@google.com
On 2015/04/03 14:50:23, mtklein_C wrote: > +Leon, can you make sure I've got my libpng logic right? LGTM. FWIW, we already were not building libpng with neon properly. Part of Derek's change to allow two versions of libpng (https://codereview.chromium.org/1032253003 - which got reverted) builds the right files when we're building for neon. > > I believe Android always goes down the non-static path here today, so disabling > NEON in the static libpng doesn't affect Android. > > Should be that as of this change, we go from having 0 non-Android NEON devices > to 1, Daisy. So this setting really only affects Daisy. I'm leaving it TBD to > figure out how to compile the libpng NEON code and turn it back on.
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054233002/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/ac813d8a1212bf31c75a564a57fe5240edb84019 |
