Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: platform_tools/chromeos/bin/chromeos_setup.sh

Issue 1054233002: Try ARMv7 and NEON for Daisy. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/libpng.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/chromeos/bin/chromeos_setup.sh
diff --git a/platform_tools/chromeos/bin/chromeos_setup.sh b/platform_tools/chromeos/bin/chromeos_setup.sh
index de4d6f99ca01e8d5846beb6dd1ecef3ea2eab603..b04eb1b31029e6731d873abdbc9e8d3e944fe701 100755
--- a/platform_tools/chromeos/bin/chromeos_setup.sh
+++ b/platform_tools/chromeos/bin/chromeos_setup.sh
@@ -34,8 +34,7 @@ setup_device() {
GENERIC_BOARD_TYPE="amd64-generic"
;;
daisy)
- # TODO(mtklein): make this arm_version=7 arm_neon=1
- DEFINES="${DEFINES} skia_arch_type=arm"
+ DEFINES="${DEFINES} skia_arch_type=arm arm_version=7 arm_neon=1"
# TODO(borenet): We have to define skia_warnings_as_errors=0 for the arm
# build, which throws lots of "mangling of va_list has changed" warnings.
DEFINES="${DEFINES} skia_warnings_as_errors=0"
« no previous file with comments | « gyp/libpng.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698