Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/libpng.gyp

Issue 1054233002: Try ARMv7 and NEON for Daisy. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/chromeos/bin/chromeos_setup.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/libpng.gyp
diff --git a/gyp/libpng.gyp b/gyp/libpng.gyp
index 1ca6eef25343498577152b422f2c8ebf48c4c573..73bdd2aa3cbd5cd36610f74115f36c07ebc7919e 100644
--- a/gyp/libpng.gyp
+++ b/gyp/libpng.gyp
@@ -36,15 +36,9 @@
'-w',
'-fvisibility=hidden',
],
- 'conditions': [
- ['not arm_neon', {
- 'defines': [
- # FIXME: Why is this needed? Without it, pngpriv.h sets it
- # to 2 if __ARM_NEON is defined, but shouldn't __ARM_NEON
- # not be defined since arm_neon is 0?
- 'PNG_ARM_NEON_OPT=0',
- ],
- }],
+ 'defines': [
+ # TODO: it'd be nice to enable PNG's NEON when possible.
+ 'PNG_ARM_NEON_OPT=0',
],
'sources': [
'../third_party/externals/libpng/png.c',
« no previous file with comments | « no previous file | platform_tools/chromeos/bin/chromeos_setup.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698