Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1053873002: Fix GLSL error on Android. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@filters-use-scratch-textures
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GLSL error on Android. BUG=skia: TBR=bsalomon NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f90cd8e0e39af02c3826c80366efa3c06e88f642

Patch Set 1 #

Patch Set 2 : fixie #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053873002/1
5 years, 8 months ago (2015-04-01 22:05:22 UTC) #2
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years, 8 months ago (2015-04-01 22:05:24 UTC) #4
rmistry
On 2015/04/01 22:05:24, I haz the power (commit-bot) wrote: > Internal error: failed to checkout. ...
5 years, 8 months ago (2015-04-01 22:07:43 UTC) #5
rmistry
On 2015/04/01 22:07:43, rmistry wrote: > On 2015/04/01 22:05:24, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-01 22:08:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053873002/20001
5 years, 8 months ago (2015-04-01 22:13:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f90cd8e0e39af02c3826c80366efa3c06e88f642
5 years, 8 months ago (2015-04-01 22:13:33 UTC) #9
rmistry
On 2015/04/01 22:13:33, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:20001) as ...
5 years, 8 months ago (2015-04-01 22:37:37 UTC) #10
rmistry
On 2015/04/01 22:37:37, rmistry wrote: > On 2015/04/01 22:13:33, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-01 22:38:42 UTC) #11
rmistry
5 years, 8 months ago (2015-04-01 22:50:51 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1056713002/ by rmistry@google.com.

The reason for reverting is: Spoke to Stephan about this. Reverting because
failing debug builds:

https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Mac10.9-Clan...
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-S....

Powered by Google App Engine
This is Rietveld 408576698