Issue 105193002: Replace string16 with base::string16.

Issue 105193002: Replace string16 with base::string16. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, browser-components-watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, vsevik, aboxhall+watch_chromium.org, Ilya Sherman, nona+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, dtseng+watch_chromium.org, derat+watch_chromium.org, benjhayden+dwatch_chromium.org, yoshiki+watch_chromium.org, davemoore+watch_chromium.org, yuzo+watch_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, pfeldman, rouslan+autofillwatch_chromium.org, plundblad+watch_chromium.org, tfarina, yurys, benquan, robertshield, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace string16 with base::string16. This updates portions of chrome/browser/... to use the base namespace. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238766

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1335 lines, -1279 lines)			Patch
M	chrome/browser/about_flags.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/accessibility/accessibility_extension_api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/bookmarks_bridge.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/bookmarks_bridge.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/managed_bookmarks_shim.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/dev_tools_server.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/android/intent_helper.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/android/intent_helper.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/android/most_visited_sites.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/password_ui_view_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/password_ui_view_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/provider/chrome_browser_provider.cc	View		29 chunks	+42 lines, -40 lines	0 comments	Download
M	chrome/browser/android/shortcut_helper.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/android/shortcut_helper.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/android/tab_android.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/android/tab_android.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View		3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/apps/app_url_redirector_browsertest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/apps/shortcut_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/apps/web_view_browsertest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/apps/web_view_interactive_browsertest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_browsertest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_classifier.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_classifier.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_controller.cc	View		9 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input.h	View		7 chunks	+16 lines, -15 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input.cc	View		18 chunks	+33 lines, -30 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input_unittest.cc	View	1	8 chunks	+22 lines, -18 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.h	View		8 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View		6 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider_unittest.cc	View		15 chunks	+25 lines, -24 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_result.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_result_unittest.cc	View		8 chunks	+16 lines, -8 lines	0 comments	Download
M	chrome/browser/autocomplete/bookmark_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/bookmark_provider_unittest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/builtin_provider.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/builtin_provider.cc	View		6 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/browser/autocomplete/builtin_provider_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/contact_provider_chromeos.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/contact_provider_chromeos.cc	View	1 2	8 chunks	+19 lines, -19 lines	0 comments	Download
M	chrome/browser/autocomplete/contact_provider_chromeos_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider.cc	View		2 chunks	+14 lines, -12 lines	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider_unittest.cc	View		4 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/history_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_provider.cc	View		4 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/history_provider_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider_unittest.cc	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View		12 chunks	+20 lines, -18 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.h	View		12 chunks	+35 lines, -35 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider_unittest.cc	View		22 chunks	+34 lines, -34 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider.h	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View		11 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/autocomplete/url_prefix.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/url_prefix.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/zero_suggest_provider.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/zero_suggest_provider.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/autofill/autofill_browsertest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/autofill_cc_infobar_delegate.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/autofill_cc_infobar_delegate.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/autofill_driver_impl_browsertest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/autofill_interactive_uitest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View		15 chunks	+26 lines, -26 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/background/background_application_list_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background/background_contents_service.h	View		6 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/background/background_contents_service.cc	View		11 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/background/background_contents_service_unittest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager.h	View		5 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background/background_mode_manager_chromeos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background/background_mode_manager_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background/background_mode_manager_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/background/background_mode_manager_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View		5 chunks	+35 lines, -29 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_index.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_index.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.h	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View		19 chunks	+19 lines, -19 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data_unittest.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_tag_model.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_tag_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_tag_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_indexed_db_helper.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data/cookies_tree_model.h	View		4 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/browsing_data/cookies_tree_model.cc	View		19 chunks	+31 lines, -31 lines	0 comments	Download
M	chrome/browser/browsing_data/cookies_tree_model_unittest.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/captive_portal/captive_portal_browsertest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/captive_portal/captive_portal_tab_helper.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/captive_portal/captive_portal_tab_helper.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc	View	1	21 chunks	+40 lines, -39 lines	0 comments	Download
M	chrome/browser/certificate_manager_model.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/certificate_manager_model.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/character_encoding.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/character_encoding.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_win.cc	View		8 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_plugin_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chrome_process_finder_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chrome_quota_permission_context.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/choose_mobile_network_dialog.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/choose_mobile_network_dialog.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/enrollment_dialog_view.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc	View		6 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/external_protocol_dialog.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/external_protocol_dialog.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/desktop_notifications.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/desktop_notifications.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/desktop_notifications_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/file_browser_handlers.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/file_manager/select_file_dialog_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/file_manager/select_file_dialog_util.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/url_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/file_manager/url_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/drive_first_run_controller.cc	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_view.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/infolist_window_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_delegate_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_delegate_impl.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View		8 chunks	+14 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mode_indicator_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/mode_indicator_delegate_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/mode_indicator_delegate_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/textinput_surroundingtext_browsertest.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/textinput_test_helper.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/textinput_test_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/locale_change_guard.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/locale_change_guard.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/captive_portal_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/captive_portal_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/default_user_images.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/default_user_images.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/fake_supervised_user_manager.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/fake_supervised_user_manager.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/fake_user_manager.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/fake_user_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/helper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/language_list.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/language_list.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_display.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_utils_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_web_dialog.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_web_dialog.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_controller.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc	View		7 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_user_manager.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/proxy_settings_dialog.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker_tester.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/screens/mock_network_screen.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/network_screen.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/network_screen.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/network_screen_actor.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/network_screen_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/supervised_user_manager.h	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/supervised_user_manager_impl.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/supervised_user_manager_impl.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/user.h	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/user.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_view.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_screen_locker.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/webui_screen_locker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/options/cert_library.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/options/cert_library.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/passphrase_textfield.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/vpn_config_view.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/options/vpn_config_view.cc	View		11 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.cc	View		17 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/options/wimax_config_view.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/wimax_config_view.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/policy/device_local_account_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/power/idle_action_warning_dialog_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/power/peripheral_battery_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc	View		12 chunks	+24 lines, -24 lines	0 comments	Download
M	chrome/browser/chromeos/settings/system_settings_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/data_promo_notification.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/system/timezone_util.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/ui/echo_dialog_view.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/ui/echo_dialog_view.cc	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/ui/idle_logout_dialog_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/ui/idle_logout_dialog_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/ui/screen_capture_notification_ui_chromeos.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/ui/screen_capture_notification_ui_chromeos.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_browsertest.cc	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_usages_state.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/content_settings/tab_specific_content_settings.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/crash_recovery_browsertest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/custom_home_pages_table_model.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/custom_home_pages_table_model.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/devtools_file_helper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_sanity_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_targets_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_window.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/devtools/devtools_window.cc	View		6 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/diagnostics/diagnostics_writer.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/do_not_track_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_browsertest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_danger_prompt.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/download/download_file_picker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_item_model.h	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/download/download_item_model.cc	View		10 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/download/download_item_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_query.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/download/download_query_unittest.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_request_infobar_delegate.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_request_infobar_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_status_updater_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_target_determiner.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/save_package_file_picker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

https://codereview.chromium.org/105193002/diff/20001/chrome/browser/autocomplete/contact_provider_chromeos.cc File chrome/browser/autocomplete/contact_provider_chromeos.cc (right): https://codereview.chromium.org/105193002/diff/20001/chrome/browser/autocomplete/contact_provider_chromeos.cc#newcode12 chrome/browser/autocomplete/contact_provider_chromeos.cc:12: #include "base/strings/base::string16.h" Nice. LBTM.

7 years ago (2013-12-04 19:16:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r238766.

Expand Messages | Collapse Messages