Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 105193002: Replace string16 with base::string16. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.h ('k') | chrome/browser/autocomplete/search_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/history_url_provider.cc
diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc
index 45c660b968e45e71228be773a8cb4ffdf651053d..b85e499b21799a65b09806086b1a9e9cf1a20ce1 100644
--- a/chrome/browser/autocomplete/history_url_provider.cc
+++ b/chrome/browser/autocomplete/history_url_provider.cc
@@ -86,7 +86,7 @@ bool CreateOrPromoteMatch(const history::URLRow& info,
// URL to just a host. If this host still matches the user input, return it.
// Returns the empty string on failure.
GURL ConvertToHostOnly(const history::HistoryMatch& match,
- const string16& input) {
+ const base::string16& input) {
// See if we should try to do host-only suggestions for this URL. Nonstandard
// schemes means there's no authority section, so suggesting the host name
// is useless. File URLs are standard, but host suggestion is not useful for
@@ -101,7 +101,7 @@ GURL ConvertToHostOnly(const history::HistoryMatch& match,
if ((host.spec().length() < (match.input_location + input.length())))
return GURL(); // User typing is longer than this host suggestion.
- const string16 spec = UTF8ToUTF16(host.spec());
+ const base::string16 spec = UTF8ToUTF16(host.spec());
if (spec.compare(match.input_location, input.length(), input))
return GURL(); // User typing is no longer a prefix.
@@ -204,7 +204,7 @@ class SearchTermsDataSnapshot : public SearchTermsData {
virtual std::string GoogleBaseURLValue() const OVERRIDE;
virtual std::string GetApplicationLocale() const OVERRIDE;
- virtual string16 GetRlzParameterValue() const OVERRIDE;
+ virtual base::string16 GetRlzParameterValue() const OVERRIDE;
virtual std::string GetSearchClient() const OVERRIDE;
virtual std::string ForceInstantResultsParam(
bool for_prerender) const OVERRIDE;
@@ -214,7 +214,7 @@ class SearchTermsDataSnapshot : public SearchTermsData {
private:
std::string google_base_url_value_;
std::string application_locale_;
- string16 rlz_parameter_value_;
+ base::string16 rlz_parameter_value_;
std::string search_client_;
std::string force_instant_results_param_;
std::string instant_extended_enabled_param_;
@@ -246,7 +246,7 @@ std::string SearchTermsDataSnapshot::GetApplicationLocale() const {
return application_locale_;
}
-string16 SearchTermsDataSnapshot::GetRlzParameterValue() const {
+base::string16 SearchTermsDataSnapshot::GetRlzParameterValue() const {
return rlz_parameter_value_;
}
@@ -399,7 +399,7 @@ void HistoryURLProvider::Stop(bool clear_cached_results) {
}
AutocompleteMatch HistoryURLProvider::SuggestExactInput(
- const string16& text,
+ const base::string16& text,
const GURL& destination_url,
bool trim_http) {
AutocompleteMatch match(this, 0, false,
@@ -415,7 +415,8 @@ AutocompleteMatch HistoryURLProvider::SuggestExactInput(
// slightly different behavior as well (the latter will strip even without
// two slashes after the scheme).
DCHECK(!trim_http || !AutocompleteInput::HasHTTPScheme(text));
- string16 display_string(StringForURLDisplay(destination_url, false, false));
+ base::string16 display_string(
+ StringForURLDisplay(destination_url, false, false));
const size_t offset = trim_http ? TrimHttpPrefix(&display_string) : 0;
match.fill_into_edit =
AutocompleteInput::FormattedStringWithEquivalentMeaning(destination_url,
@@ -527,7 +528,8 @@ void HistoryURLProvider::DoAutocomplete(history::HistoryBackend* backend,
for (history::URLRows::const_iterator j(url_matches.begin());
j != url_matches.end(); ++j) {
const URLPrefix* best_prefix =
- URLPrefix::BestURLPrefix(UTF8ToUTF16(j->url().spec()), string16());
+ URLPrefix::BestURLPrefix(UTF8ToUTF16(j->url().spec()),
+ base::string16());
DCHECK(best_prefix != NULL);
history_matches.push_back(history::HistoryMatch(*j, i->prefix.length(),
i->num_components == 0,
@@ -825,8 +827,8 @@ bool HistoryURLProvider::FixupExactSuggestion(
return false;
// Put it on the front of the HistoryMatches for redirect culling.
- CreateOrPromoteMatch(classifier.url_row(), string16::npos, false, matches,
- true, true);
+ CreateOrPromoteMatch(classifier.url_row(), base::string16::npos, false,
+ matches, true, true);
return true;
}
@@ -1060,7 +1062,7 @@ AutocompleteMatch HistoryURLProvider::HistoryMatchToACMatch(
net::UnescapeRule::SPACES, NULL, NULL,
&inline_autocomplete_offset));
if (!params.prevent_inline_autocomplete &&
- (inline_autocomplete_offset != string16::npos)) {
+ (inline_autocomplete_offset != base::string16::npos)) {
DCHECK(inline_autocomplete_offset <= match.fill_into_edit.length());
match.inline_autocompletion =
match.fill_into_edit.substr(inline_autocomplete_offset);
@@ -1068,21 +1070,21 @@ AutocompleteMatch HistoryURLProvider::HistoryMatchToACMatch(
// The latter part of the test effectively asks "is the inline completion
// empty?" (i.e., is this match effectively the what-you-typed match?).
match.allowed_to_be_default_match = !params.prevent_inline_autocomplete ||
- ((inline_autocomplete_offset != string16::npos) &&
+ ((inline_autocomplete_offset != base::string16::npos) &&
(inline_autocomplete_offset >= match.fill_into_edit.length()));
size_t match_start = history_match.input_location;
match.contents = net::FormatUrl(info.url(), languages,
format_types, net::UnescapeRule::SPACES, NULL, NULL, &match_start);
- if ((match_start != string16::npos) &&
- (inline_autocomplete_offset != string16::npos) &&
+ if ((match_start != base::string16::npos) &&
+ (inline_autocomplete_offset != base::string16::npos) &&
(inline_autocomplete_offset != match_start)) {
DCHECK(inline_autocomplete_offset > match_start);
AutocompleteMatch::ClassifyLocationInString(match_start,
inline_autocomplete_offset - match_start, match.contents.length(),
ACMatchClassification::URL, &match.contents_class);
} else {
- AutocompleteMatch::ClassifyLocationInString(string16::npos, 0,
+ AutocompleteMatch::ClassifyLocationInString(base::string16::npos, 0,
match.contents.length(), ACMatchClassification::URL,
&match.contents_class);
}
@@ -1095,9 +1097,9 @@ AutocompleteMatch HistoryURLProvider::HistoryMatchToACMatch(
// static
ACMatchClassifications HistoryURLProvider::ClassifyDescription(
- const string16& input_text,
- const string16& description) {
- string16 clean_description = history::CleanUpTitleForMatching(description);
+ const base::string16& input_text,
+ const base::string16& description) {
+ base::string16 clean_description = history::CleanUpTitleForMatching(description);
history::TermMatches description_matches(SortAndDeoverlapMatches(
history::MatchTermInString(input_text, clean_description, 0)));
history::WordStarts description_word_starts;
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.h ('k') | chrome/browser/autocomplete/search_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698