Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/browser/bookmarks/bookmark_model.cc

Issue 105193002: Replace string16 with base::string16. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.h ('k') | chrome/browser/bookmarks/bookmark_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_model.cc
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc
index 433309e8e8002ba55a37f1fa58d2e8640ec5cdb2..9912694b027dd6ac24c2ad4f313d78656b33fc5c 100644
--- a/chrome/browser/bookmarks/bookmark_model.cc
+++ b/chrome/browser/bookmarks/bookmark_model.cc
@@ -70,10 +70,10 @@ BookmarkNode::BookmarkNode(int64 id, const GURL& url)
BookmarkNode::~BookmarkNode() {
}
-void BookmarkNode::SetTitle(const string16& title) {
+void BookmarkNode::SetTitle(const base::string16& title) {
// Replace newlines and other problematic whitespace characters in
// folder/bookmark names with spaces.
- string16 trimmed_title;
+ base::string16 trimmed_title;
base::ReplaceChars(title, kInvalidChars, ASCIIToUTF16(" "), &trimmed_title);
ui::TreeNode<BookmarkNode>::SetTitle(trimmed_title);
}
@@ -398,7 +398,7 @@ const gfx::Image& BookmarkModel::GetFavicon(const BookmarkNode* node) {
return node->favicon();
}
-void BookmarkModel::SetTitle(const BookmarkNode* node, const string16& title) {
+void BookmarkModel::SetTitle(const BookmarkNode* node, const base::string16& title) {
if (!node) {
NOTREACHED();
return;
@@ -602,7 +602,7 @@ const BookmarkNode* BookmarkModel::GetNodeByID(int64 id) const {
const BookmarkNode* BookmarkModel::AddFolder(const BookmarkNode* parent,
int index,
- const string16& title) {
+ const base::string16& title) {
if (!loaded_ || is_root_node(parent) || !IsValidIndex(parent, index, true)) {
// Can't add to the root.
NOTREACHED();
@@ -620,7 +620,7 @@ const BookmarkNode* BookmarkModel::AddFolder(const BookmarkNode* parent,
const BookmarkNode* BookmarkModel::AddURL(const BookmarkNode* parent,
int index,
- const string16& title,
+ const base::string16& title,
const GURL& url) {
return AddURLWithCreationTime(parent, index,
CollapseWhitespace(title, false),
@@ -630,7 +630,7 @@ const BookmarkNode* BookmarkModel::AddURL(const BookmarkNode* parent,
const BookmarkNode* BookmarkModel::AddURLWithCreationTime(
const BookmarkNode* parent,
int index,
- const string16& title,
+ const base::string16& title,
const GURL& url,
const Time& creation_time) {
if (!loaded_ || !url.is_valid() || is_root_node(parent) ||
@@ -717,7 +717,7 @@ void BookmarkModel::ResetDateFolderModified(const BookmarkNode* node) {
}
void BookmarkModel::GetBookmarksWithTitlesMatching(
- const string16& text,
+ const base::string16& text,
size_t max_count,
std::vector<BookmarkTitleMatch>* matches) {
if (!loaded_)
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.h ('k') | chrome/browser/bookmarks/bookmark_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698