Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1051863003: Turn ThreadPriority enum into an enum class. (Closed)

Created:
5 years, 8 months ago by gab
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@setthreadpri
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn ThreadPriority enum into an enum class. Adding some type safety as it is often used in close proximity with OS-level raw integer priorities. Also fixing nomenclature to use CHROMIUM_STYLE_ENUM_NAMES rather than kGoogleStyleEnumNames: https://www.chromium.org/developers/coding-style#Naming And lastly, sorting the declaration order by importance. TBR=jam BUG=456903 Committed: https://crrev.com/9a47073b992032eccd980693076a2dfb5dab429d Cr-Commit-Position: refs/heads/master@{#323359}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rm whitespace #

Patch Set 3 : merge up to r323323 #

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -85 lines) Patch
M base/threading/platform_thread.h View 1 2 3 1 chunk +10 lines, -8 lines 0 comments Download
M base/threading/platform_thread_android.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M base/threading/platform_thread_freebsd.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M base/threading/platform_thread_internal_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/platform_thread_linux.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M base/threading/platform_thread_mac.mm View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 1 2 3 7 chunks +14 lines, -12 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_device_thread.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
gab
Ricardo PTAL, as promised in https://codereview.chromium.org/1006933003/. Cheers, Gab
5 years, 8 months ago (2015-04-01 18:45:28 UTC) #3
gab
On 2015/04/01 18:45:28, gab wrote: > Ricardo PTAL, as promised in https://codereview.chromium.org/1006933003/. Ricardo please double-check ...
5 years, 8 months ago (2015-04-01 18:48:51 UTC) #5
rvargas (doing something else)
https://codereview.chromium.org/1051863003/diff/20001/base/threading/platform_thread.h File base/threading/platform_thread.h (right): https://codereview.chromium.org/1051863003/diff/20001/base/threading/platform_thread.h#newcode123 base/threading/platform_thread.h:123: REALTIMEAUDIO, nit: REALTIME_AUDIO ? https://codereview.chromium.org/1051863003/diff/20001/base/threading/platform_thread_win.cc File base/threading/platform_thread_win.cc (right): https://codereview.chromium.org/1051863003/diff/20001/base/threading/platform_thread_win.cc#newcode239 ...
5 years, 8 months ago (2015-04-01 19:10:36 UTC) #7
rvargas (doing something else)
Other than that, lgtm
5 years, 8 months ago (2015-04-01 19:12:36 UTC) #8
gab
Thanks, done. https://codereview.chromium.org/1051863003/diff/20001/base/threading/platform_thread.h File base/threading/platform_thread.h (right): https://codereview.chromium.org/1051863003/diff/20001/base/threading/platform_thread.h#newcode123 base/threading/platform_thread.h:123: REALTIMEAUDIO, On 2015/04/01 19:10:35, rvargas (soon out ...
5 years, 8 months ago (2015-04-01 21:05:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051863003/80001
5 years, 8 months ago (2015-04-01 21:07:05 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 8 months ago (2015-04-01 23:05:19 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 23:06:29 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9a47073b992032eccd980693076a2dfb5dab429d
Cr-Commit-Position: refs/heads/master@{#323359}

Powered by Google App Engine
This is Rietveld 408576698