Improvements to the offline intersitial and easter egg

Improvements to the offline intersitial and easter egg
- Fix right click restart bug.
- Switched image assets to use sprite sheets.
- Fix resizing whilst jumping causes delays bug.
- Add UMA counter for easter egg.
- Gameplay tweaks.

BUG=464330, 453853
Committed: https://crrev.com/8633d1fd54cb3cd6dc0aba0dc01f8284e5158ac2
Cr-Commit-Position: refs/heads/master@{#323703}

[edwardjung, 2015-03-31 18:27:10]

edwardjung@chromium.org changed reviewers:
+ arv@chromium.org, asvitkine@chromium.org, mmenke@chromium.org

[edwardjung, 2015-03-31 18:27:11]

mmenke could you take a look at:
  chrome/renderer/net/net_error_page_controller.h
  chrome/renderer/net/net_error_page_controller.cc

arv resources files:
 chrome/renderer/resources/*

asvitkine:
  tools/metrics/actions/actions.xml

Thanks.

[mmenke, 2015-03-31 18:39:08]

net_error_page_controller LGTM

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
File chrome/renderer/net/net_error_page_controller.cc (right):

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
chrome/renderer/net/net_error_page_controller.cc:93:
base::UserMetricsAction("DinosaurEasterEgg"));
nit:  +2 indent

[Alexei Svitkine (slow), 2015-03-31 19:08:40]

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
File chrome/renderer/net/net_error_page_controller.cc (right):

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
chrome/renderer/net/net_error_page_controller.cc:93:
base::UserMetricsAction("DinosaurEasterEgg"));
Is there a reason you're using an action and not a histogram here?

Histograms generally offer better support from our dashboards. For example, you
could have a histogram with two buckets, one tracking how many times the error
page was shown and another for the easter egg being activated - so you can get a
sense of what percent of users actually use it (rather than just absolute counts
which don't say much in a vacuum).

[arv (Not doing code reviews), 2015-03-31 19:10:56]

LGTM with nits

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
File chrome/renderer/resources/offline.js (right):

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:275: * Cache the approprate image sprite
from the page and get the sprite sheet
typo

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:698: return e.which && e.which < 2 &&
e.type == Runner.events.MOUSEUP &&
Use e.button instead of of e.which.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:936: * @param {object} textImgPos
s/object/Object/

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:1396: type: 'PTERODACTYL',
New game elements. Exciting!

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:2274: * @param {object} dimensions Canvas
dimensions.
typo here too

[edwardjung, 2015-04-01 10:40:47]

Alexei, I've updated the code to now use the existing histogram. Please take
another look. 

@mmenke, apologies, could you have a look at the updated code. Had to make
additional changes to:
  components/error_page/common/net_error_info.h	
  components/error_page/renderer/net_error_helper_core.h
  components/error_page/renderer/net_error_helper_core.cc

Thanks.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
File chrome/renderer/net/net_error_page_controller.cc (right):

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
chrome/renderer/net/net_error_page_controller.cc:93:
base::UserMetricsAction("DinosaurEasterEgg"));
On 2015/03/31 18:39:08, mmenke wrote:
> nit:  +2 indent

Done.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/net/net...
chrome/renderer/net/net_error_page_controller.cc:93:
base::UserMetricsAction("DinosaurEasterEgg"));
Good point. I dug in a but deeper and it turns out there is a network error
histogram set up. Missed it as it wrapped in multiple classes. Have updated the
code accordingly.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
File chrome/renderer/resources/offline.js (right):

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:275: * Cache the approprate image sprite
from the page and get the sprite sheet
On 2015/03/31 19:10:56, arv wrote:
> typo

Done.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:698: return e.which && e.which < 2 &&
e.type == Runner.events.MOUSEUP &&
On 2015/03/31 19:10:56, arv wrote:
> Use e.button instead of of e.which.

Done.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:1396: type: 'PTERODACTYL',
On 2015/03/31 19:10:56, arv wrote:
> New game elements. Exciting!

Acknowledged.

https://codereview.chromium.org/1051433002/diff/40001/chrome/renderer/resourc...
chrome/renderer/resources/offline.js:2274: * @param {object} dimensions Canvas
dimensions.
On 2015/03/31 19:10:56, arv wrote:
> typo here too

Done.

[Alexei Svitkine (slow), 2015-04-01 14:03:06]

histograms lgtm

https://codereview.chromium.org/1051433002/diff/80001/chrome/renderer/net/net...
File chrome/renderer/net/net_error_helper.h (right):

https://codereview.chromium.org/1051433002/diff/80001/chrome/renderer/net/net...
chrome/renderer/net/net_error_helper.h:87: void TrackActivatedEasterEgg();
Nit: Add an empty line after this.

[edwardjung, 2015-04-02 16:26:34]

All done.

mmenke, could I get a re review of the changes to:
  components/error_page/common/net_error_info.h	
  components/error_page/renderer/net_error_helper_core.h
  components/error_page/renderer/net_error_helper_core.cc

Want to get this checked in before the branch point.

Thanks.

https://codereview.chromium.org/1051433002/diff/80001/chrome/renderer/net/net...
File chrome/renderer/net/net_error_helper.h (right):

https://codereview.chromium.org/1051433002/diff/80001/chrome/renderer/net/net...
chrome/renderer/net/net_error_helper.h:87: void TrackActivatedEasterEgg();
On 2015/04/01 14:03:06, Alexei Svitkine wrote:
> Nit: Add an empty line after this.

Done.

[mmenke, 2015-04-02 16:30:56]

components/error_page still LGTM (And looks better than before).

On 2015/04/02 16:26:34, edwardjung wrote:
> All done.
> 
> mmenke, could I get a re review of the changes to:
>   components/error_page/common/net_error_info.h	
>   components/error_page/renderer/net_error_helper_core.h
>   components/error_page/renderer/net_error_helper_core.cc
> 
> Want to get this checked in before the branch point.
> 
> Thanks.
> 
>
https://codereview.chromium.org/1051433002/diff/80001/chrome/renderer/net/net...
> File chrome/renderer/net/net_error_helper.h (right):
> 
>
https://codereview.chromium.org/1051433002/diff/80001/chrome/renderer/net/net...
> chrome/renderer/net/net_error_helper.h:87: void TrackActivatedEasterEgg();
> On 2015/04/01 14:03:06, Alexei Svitkine wrote:
> > Nit: Add an empty line after this.
> 
> Done.

[edwardjung, 2015-04-02 16:32:36]

The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run

[edwardjung, 2015-04-02 16:32:37]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1051433002/#ps100001
(title: "Fix nits")

[commit-bot: I haz the power, 2015-04-02 16:33:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051433002/100001

[commit-bot: I haz the power, 2015-04-02 16:47:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051433002/100001

[commit-bot: I haz the power, 2015-04-02 17:02:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051433002/100001

[commit-bot: I haz the power, 2015-04-02 17:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 17:56:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[edwardjung, 2015-04-02 18:17:04]

The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run

[edwardjung, 2015-04-02 18:17:05]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org,
asvitkine@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1051433002/#ps120001
(title: "Darn it, keep forgetting CrOS has a separate offline template!")

[commit-bot: I haz the power, 2015-04-02 18:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051433002/120001

[commit-bot: I haz the power, 2015-04-03 04:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 04:52:45]

This issue passed the CQ dry run.

[edwardjung, 2015-04-03 08:29:32]

The CQ bit was checked by edwardjung@chromium.org

[commit-bot: I haz the power, 2015-04-03 08:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051433002/120001

[commit-bot: I haz the power, 2015-04-03 08:31:46]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-04-03 20:36:00]

Patchset 7 (id:??) landed as
https://crrev.com/8633d1fd54cb3cd6dc0aba0dc01f8284e5158ac2
Cr-Commit-Position: refs/heads/master@{#323703}