Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Side by Side Diff: chrome/renderer/net/net_error_helper.h

Issue 1051433002: Improvements to the offline intersitial and easter egg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove actions.xml and unused includes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 5 #ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
6 #define CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 6 #define CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 bool is_failed_post, 76 bool is_failed_post,
77 std::string* error_html); 77 std::string* error_html);
78 78
79 // Returns whether a load for |url| in |frame| should have its error page 79 // Returns whether a load for |url| in |frame| should have its error page
80 // suppressed. 80 // suppressed.
81 bool ShouldSuppressErrorPage(blink::WebFrame* frame, const GURL& url); 81 bool ShouldSuppressErrorPage(blink::WebFrame* frame, const GURL& url);
82 82
83 // Called when a link with the given tracking ID is pressed. 83 // Called when a link with the given tracking ID is pressed.
84 void TrackClick(int tracking_id); 84 void TrackClick(int tracking_id);
85 85
86 // Tracks easter egg activations on the offline interstitial.
87 void TrackActivatedEasterEgg();
Alexei Svitkine (slow) 2015/04/01 14:03:06 Nit: Add an empty line after this.
edwardjung 2015/04/02 16:26:34 Done.
86 private: 88 private:
87 // NetErrorHelperCore::Delegate implementation: 89 // NetErrorHelperCore::Delegate implementation:
88 void GenerateLocalizedErrorPage( 90 void GenerateLocalizedErrorPage(
89 const blink::WebURLError& error, 91 const blink::WebURLError& error,
90 bool is_failed_post, 92 bool is_failed_post,
91 scoped_ptr<error_page::ErrorPageParams> params, 93 scoped_ptr<error_page::ErrorPageParams> params,
92 bool* reload_button_shown, 94 bool* reload_button_shown,
93 bool* show_saved_copy_button_shown, 95 bool* show_saved_copy_button_shown,
94 std::string* html) const override; 96 std::string* html) const override;
95 void LoadErrorPageInMainFrame(const std::string& html, 97 void LoadErrorPageInMainFrame(const std::string& html,
(...skipping 25 matching lines...) Expand all
121 123
122 scoped_ptr<content::ResourceFetcher> correction_fetcher_; 124 scoped_ptr<content::ResourceFetcher> correction_fetcher_;
123 scoped_ptr<content::ResourceFetcher> tracking_fetcher_; 125 scoped_ptr<content::ResourceFetcher> tracking_fetcher_;
124 126
125 scoped_ptr<error_page::NetErrorHelperCore> core_; 127 scoped_ptr<error_page::NetErrorHelperCore> core_;
126 128
127 DISALLOW_COPY_AND_ASSIGN(NetErrorHelper); 129 DISALLOW_COPY_AND_ASSIGN(NetErrorHelper);
128 }; 130 };
129 131
130 #endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 132 #endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698