Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: components/error_page/common/net_error_info.h

Issue 1051433002: Improvements to the offline intersitial and easter egg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Darn it, keep forgetting CrOS has a separate offline template! Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_ 5 #ifndef COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_
6 #define COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_ 6 #define COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_
7 7
8 // TODO(hashimoto): Change this to namespace error_page. 8 // TODO(hashimoto): Change this to namespace error_page.
9 namespace chrome_common_net { 9 namespace chrome_common_net {
10 10
(...skipping 13 matching lines...) Expand all
24 24
25 NETWORK_ERROR_PAGE_MORE_BUTTON_CLICKED, // More button clicked. 25 NETWORK_ERROR_PAGE_MORE_BUTTON_CLICKED, // More button clicked.
26 26
27 NETWORK_ERROR_PAGE_BROWSER_INITIATED_RELOAD, // Reload from browser. 27 NETWORK_ERROR_PAGE_BROWSER_INITIATED_RELOAD, // Reload from browser.
28 28
29 // Keep track of which button the user chooses when both are shown. 29 // Keep track of which button the user chooses when both are shown.
30 NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN, 30 NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN,
31 NETWORK_ERROR_PAGE_BOTH_BUTTONS_RELOAD_CLICKED, 31 NETWORK_ERROR_PAGE_BOTH_BUTTONS_RELOAD_CLICKED,
32 NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN_SAVED_COPY_CLICKED, 32 NETWORK_ERROR_PAGE_BOTH_BUTTONS_SHOWN_SAVED_COPY_CLICKED,
33 33
34 NETWORK_ERROR_EASTER_EGG_ACTIVATED, // Easter egg activated.
35
34 NETWORK_ERROR_PAGE_EVENT_MAX, 36 NETWORK_ERROR_PAGE_EVENT_MAX,
35 }; 37 };
36 38
37 // The status of a DNS probe. 39 // The status of a DNS probe.
38 // 40 //
39 // The DNS_PROBE_FINISHED_* values are used in histograms, so: 41 // The DNS_PROBE_FINISHED_* values are used in histograms, so:
40 // 1. FINISHED_UNKNOWN must remain the first FINISHED_* value. 42 // 1. FINISHED_UNKNOWN must remain the first FINISHED_* value.
41 // 2. FINISHED_* values must not be rearranged relative to FINISHED_UNKNOWN. 43 // 2. FINISHED_* values must not be rearranged relative to FINISHED_UNKNOWN.
42 // 3. New FINISHED_* values must be inserted at the end. 44 // 3. New FINISHED_* values must be inserted at the end.
43 // 4. New non-FINISHED_* values cannot be inserted. 45 // 4. New non-FINISHED_* values cannot be inserted.
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // Record specific error page events. 91 // Record specific error page events.
90 void RecordEvent(NetworkErrorPageEvent event); 92 void RecordEvent(NetworkErrorPageEvent event);
91 93
92 // The error domain used to pass DNS probe statuses to the localized error 94 // The error domain used to pass DNS probe statuses to the localized error
93 // code. 95 // code.
94 extern const char kDnsProbeErrorDomain[]; 96 extern const char kDnsProbeErrorDomain[];
95 97
96 } // namespace chrome_common_net 98 } // namespace chrome_common_net
97 99
98 #endif // COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_ 100 #endif // COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_
OLDNEW
« no previous file with comments | « chrome/renderer/resources/offline.js ('k') | components/error_page/renderer/net_error_helper_core.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698