Non-SFI: move socketpair() from plugin process to browser process.

components/nacl/common/nacl_types.h

Index: components/nacl/common/nacl_types.h
diff --git a/components/nacl/common/nacl_types.h b/components/nacl/common/nacl_types.h
index a3b9eec4e7ea82e60bb27a1df0b408f01674723e..8fd8f9c487cfd11c0b0172465b9f8f165e139621 100644
--- a/components/nacl/common/nacl_types.h
+++ b/components/nacl/common/nacl_types.h
@@ -81,6 +81,17 @@ struct NaClStartParams {
   IPC::PlatformFileForTransit debug_stub_server_bound_socket;
 #endif
 
+#if defined(OS_LINUX) || defined(OS_NACL_NONSFI)
+  // These are for Non-SFI mode IPC channels.
+  // For security hardening, unlike in SFI mode, we cannot create socket pairs
+  // in plugin process. Thus, the browser process creates the ChannelHandle

[Mark Seaborn, 2015/05/12 23:24:06]

Nit: "plugin process" -> "NaCl loader process" again

[hidehiko, 2015/05/13 06:39:21]

Done.

+  // instances, and passes them to the plugin process.
+  IPC::ChannelHandle ppapi_browser_channel_handle;
+  IPC::ChannelHandle ppapi_renderer_channel_handle;
+  IPC::ChannelHandle trusted_service_channel_handle;
+  IPC::ChannelHandle manifest_service_channel_handle;
+#endif
+
   bool validation_cache_enabled;
   std::string validation_cache_key;
   // Chrome version string. Sending the version string over IPC avoids linkage