components/nacl/common/nacl_messages.h - Issue 1051243002: Non-SFI: move socketpair() from plugin process to browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/common/nacl_messages.h

Issue 1051243002: Non-SFI: move socketpair() from plugin process to browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase & reimplement Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/browser/nacl_process_host.cc ('K') | « components/nacl/browser/nacl_process_host.cc ('k') | components/nacl/common/nacl_types.h » ('j') | components/nacl/common/nacl_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/common/nacl_messages.h

diff --git a/components/nacl/common/nacl_messages.h b/components/nacl/common/nacl_messages.h

index 90bd1445d3ee84ef98c6a13447d049944bad302a..279ddd512370be5ae1d2ace3f9c534b27ef6dd1e 100644

--- a/components/nacl/common/nacl_messages.h

+++ b/components/nacl/common/nacl_messages.h

@@ -21,10 +21,16 @@ IPC_STRUCT_TRAITS_BEGIN(nacl::NaClStartParams)

IPC_STRUCT_TRAITS_MEMBER(irt_handle)

#if defined(OS_MACOSX)

IPC_STRUCT_TRAITS_MEMBER(mac_shm_fd)

-#endif

+#endif // defined(OS_MACOSX)

Mark Seaborn 2015/05/12 23:24:06 Nit: These comments are not necessary for such sho

hidehiko 2015/05/13 06:39:20 Done.

#if defined(OS_POSIX)

IPC_STRUCT_TRAITS_MEMBER(debug_stub_server_bound_socket)

-#endif

+#endif // defined(OS_POSIX)

+#if defined(OS_LINUX) || defined(OS_NACL_NONSFI)

+ IPC_STRUCT_TRAITS_MEMBER(ppapi_browser_channel_handle)

+ IPC_STRUCT_TRAITS_MEMBER(ppapi_renderer_channel_handle)

+ IPC_STRUCT_TRAITS_MEMBER(trusted_service_channel_handle)

+ IPC_STRUCT_TRAITS_MEMBER(manifest_service_channel_handle)

+#endif // defined(OS_LINUX) || defined(OS_NACL_NONSFI)

IPC_STRUCT_TRAITS_MEMBER(validation_cache_enabled)

IPC_STRUCT_TRAITS_MEMBER(validation_cache_key)

IPC_STRUCT_TRAITS_MEMBER(version)