Non-SFI: move socketpair() from plugin process to browser process.

components/nacl/common/nacl_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 #define COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 63 matching lines @@
 
   IPC::PlatformFileForTransit imc_bootstrap_handle;
   IPC::PlatformFileForTransit irt_handle;
 #if defined(OS_MACOSX)
   IPC::PlatformFileForTransit mac_shm_fd;
 #endif
 #if defined(OS_POSIX)
   IPC::PlatformFileForTransit debug_stub_server_bound_socket;
 #endif
 
+#if defined(OS_LINUX) || defined(OS_NACL_NONSFI)
+  // These are for Non-SFI mode IPC channels.
+  // For security hardening, unlike in SFI mode, we cannot create socket pairs
+  // in plugin process. Thus, the browser process creates the ChannelHandle

[Mark Seaborn, 2015/05/12 23:24:06]

Nit: "plugin process" -> "NaCl loader process" again

[hidehiko, 2015/05/13 06:39:21]

Done.

+  // instances, and passes them to the plugin process.
+  IPC::ChannelHandle ppapi_browser_channel_handle;
+  IPC::ChannelHandle ppapi_renderer_channel_handle;
+  IPC::ChannelHandle trusted_service_channel_handle;
+  IPC::ChannelHandle manifest_service_channel_handle;
+#endif
+
   bool validation_cache_enabled;
   std::string validation_cache_key;
   // Chrome version string. Sending the version string over IPC avoids linkage
   // issues in cases where NaCl is not compiled into the main Chromium
   // executable or DLL.
   std::string version;
 
   bool enable_debug_stub;
   bool enable_ipc_proxy;
 
@@ skipping 70 matching lines @@
   base::ProcessId plugin_pid;
   int plugin_child_id;
 
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 };
 
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_COMMON_NACL_TYPES_H_