Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind. (Closed)

Created:
5 years, 8 months ago by scroggo
Modified:
5 years, 8 months ago
Reviewers:
msarett, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pngRewind
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkCodec::onGetScanlineDecoder must call rewind. This mirrors the behavior in onGetPixels, and allows the implementation to share code for handling calls to rewindIfNeeded. This also fixes a bug where getScanlineDecoder was calling rewindIfNeeded and treating the result as a bool. In SkPngCodec, factor out the code to call rewindIfNeeded, and call it in both onGetPixels and onGetScanlineDecoder. Update the test to include testing the scanline decoder. Rename "gen" to "codec" now that it must be an SkCodec. BUG=skia:3257 Depends on https://codereview.chromium.org/1048423003/ (DIFFERENT ISSUE). Committed: https://skia.googlesource.com/skia/+/58421544808562973ad66b2e3b8f9da1c5b8a36f

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Patch Set 4 : All codecs can now rewind. Remove code to support unrewindable codecs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -40 lines) Patch
M include/codec/SkCodec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkCodec.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/codec/SkCodec_libpng.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 2 chunks +33 lines, -17 lines 0 comments Download
M tests/CodexTest.cpp View 1 2 3 2 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
scroggo
5 years, 8 months ago (2015-04-01 13:39:07 UTC) #2
scroggo
5 years, 8 months ago (2015-04-01 13:39:08 UTC) #3
msarett
lgtm
5 years, 8 months ago (2015-04-01 14:23:25 UTC) #4
djsollen
lgtm
5 years, 8 months ago (2015-04-01 16:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050893002/20001
5 years, 8 months ago (2015-04-01 17:24:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/256) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 8 months ago (2015-04-01 17:25:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050893002/60001
5 years, 8 months ago (2015-04-01 17:54:36 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 18:25:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/58421544808562973ad66b2e3b8f9da1c5b8a36f

Powered by Google App Engine
This is Rietveld 408576698