DescriptionSkCodec::onGetScanlineDecoder must call rewind.
This mirrors the behavior in onGetPixels, and allows the implementation
to share code for handling calls to rewindIfNeeded.
This also fixes a bug where getScanlineDecoder was calling
rewindIfNeeded and treating the result as a bool.
In SkPngCodec, factor out the code to call rewindIfNeeded, and call it
in both onGetPixels and onGetScanlineDecoder.
Update the test to include testing the scanline decoder. Rename "gen"
to "codec" now that it must be an SkCodec.
BUG=skia:3257
Depends on https://codereview.chromium.org/1048423003/ (DIFFERENT ISSUE).
Committed: https://skia.googlesource.com/skia/+/58421544808562973ad66b2e3b8f9da1c5b8a36f
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : rebase #Patch Set 4 : All codecs can now rewind. Remove code to support unrewindable codecs. #
Messages
Total messages: 14 (6 generated)
|