src/codec/SkCodec.cpp - Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec.cpp

Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind. (Closed) Base URL: https://skia.googlesource.com/skia.git@pngRewind

Patch Set: All codecs can now rewind. Remove code to support unrewindable codecs. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec.cpp

diff --git a/src/codec/SkCodec.cpp b/src/codec/SkCodec.cpp

index 4aa422c184e5b2b5e9c322787e80bb410b2c152d..5604af8d3dce27067c0439c211872f66f6e2e832 100644

--- a/src/codec/SkCodec.cpp

+++ b/src/codec/SkCodec.cpp

@@ -88,10 +88,6 @@ SkCodec::RewindState SkCodec::rewindIfNeeded() {

}

SkScanlineDecoder* SkCodec::getScanlineDecoder(const SkImageInfo& dstInfo) {

- fScanlineDecoder.reset(NULL);

- if (!rewindIfNeeded()) {

- return NULL;

- }

fScanlineDecoder.reset(this->onGetScanlineDecoder(dstInfo));

return fScanlineDecoder.get();

}

« no previous file with comments | « include/codec/SkCodec.h ('k') | src/codec/SkCodec_libpng.h » ('j') | no next file with comments »