include/codec/SkCodec.h - Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/codec/SkCodec.h

Issue 1050893002: SkCodec::onGetScanlineDecoder must call rewind. (Closed) Base URL: https://skia.googlesource.com/skia.git@pngRewind

Patch Set: All codecs can now rewind. Remove code to support unrewindable codecs. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/codec/SkCodec.h

diff --git a/include/codec/SkCodec.h b/include/codec/SkCodec.h

index 051564cf734ea0ee0129d5d20e0d73012905ad70..6f313a1c7058715c8e7c95a82ca1448b152b245e 100644

--- a/include/codec/SkCodec.h

+++ b/include/codec/SkCodec.h

@@ -121,8 +121,8 @@ protected:

/**

* Override if your codec supports scanline decoding.

- * No need to call rewindIfNeeded(), which will have already been called

- * by the base class.

+ * As in onGetPixels(), the implementation must call rewindIfNeeded() and

+ * handle as appropriate.

* @param dstInfo Info of the destination. If the dimensions do not match

* those of getInfo, this implies a scale.

« no previous file with comments | « no previous file | src/codec/SkCodec.cpp » ('j') | no next file with comments »