Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1050253003: Changed the step name for wait_for_any.py to include only one revision. (Closed)

Created:
5 years, 8 months ago by RobertoCN
Modified:
5 years, 8 months ago
Reviewers:
iannucci, qyearsley
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@hax
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Changed the step name for wait_for_any.py to include only one revision. If there are more than one, then just say how many more. This prevents us from logging a step name longer than buildbot supports. R=qyearsley@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294677

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing colon. #

Messages

Total messages: 14 (5 generated)
RobertoCN
5 years, 8 months ago (2015-04-01 20:20:13 UTC) #1
qyearsley
LGTM https://codereview.chromium.org/1050253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py File scripts/slave/recipe_modules/auto_bisect/bisector.py (right): https://codereview.chromium.org/1050253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py#newcode401 scripts/slave/recipe_modules/auto_bisect/bisector.py:401: name = 'Waiting for revision: ' + revision_list[0].revision_string ...
5 years, 8 months ago (2015-04-02 04:08:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050253003/20001
5 years, 8 months ago (2015-04-03 03:36:51 UTC) #5
commit-bot: I haz the power
Presubmit check for 1050253003-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-03 03:39:13 UTC) #7
qyearsley
Needs OWNER LGTM. Robbie, should Roberto be added as OWNER of recipes/bisect.expected? If so, it ...
5 years, 8 months ago (2015-04-03 17:09:50 UTC) #9
RobertoCN
https://codereview.chromium.org/1050253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py File scripts/slave/recipe_modules/auto_bisect/bisector.py (right): https://codereview.chromium.org/1050253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py#newcode401 scripts/slave/recipe_modules/auto_bisect/bisector.py:401: name = 'Waiting for revision: ' + revision_list[0].revision_string On ...
5 years, 8 months ago (2015-04-03 19:05:09 UTC) #10
iannucci
On 2015/04/03 at 19:05:09, robertocn wrote: > https://codereview.chromium.org/1050253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py > File scripts/slave/recipe_modules/auto_bisect/bisector.py (right): > > https://codereview.chromium.org/1050253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py#newcode401 ...
5 years, 8 months ago (2015-04-03 20:49:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1050253003/20001
5 years, 8 months ago (2015-04-03 20:50:52 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:53:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294677

Powered by Google App Engine
This is Rietveld 408576698