Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1050253003: Changed the step name for wait_for_any.py to include only one revision. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@hax
Patch Set: Removing colon. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/bad_deps_syntax.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from . import bisect_results 7 from . import bisect_results
8 from . import depot_config 8 from . import depot_config
9 9
10 _DEPS_SHA_PATCH = """ 10 _DEPS_SHA_PATCH = """
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 for revision in revision_list: 391 for revision in revision_list:
392 revision.update_status() 392 revision.update_status()
393 393
394 def sleep_until_next_revision_ready(self, revision_list): 394 def sleep_until_next_revision_ready(self, revision_list):
395 """Produces a single step that sleeps until any revision makes progress. 395 """Produces a single step that sleeps until any revision makes progress.
396 396
397 A revision is considered to make progress when a build file is uploaded to 397 A revision is considered to make progress when a build file is uploaded to
398 the appropriate bucket, or when buildbot test job is complete. 398 the appropriate bucket, or when buildbot test job is complete.
399 """ 399 """
400 gsutil_path = self.api.m.gsutil.get_gsutil_path() 400 gsutil_path = self.api.m.gsutil.get_gsutil_path()
401 name = 'Waiting for any of these revisions:' + ' '.join( 401 name = 'Waiting for revision ' + revision_list[0].revision_string
402 [r.revision_string for r in revision_list]) 402 if len(revision_list) > 1:
403 name += ' and %d other revision(s).' % (len(revision_list) - 1)
403 script = self.api.resource('wait_for_any.py') 404 script = self.api.resource('wait_for_any.py')
404 args_list = [gsutil_path] 405 args_list = [gsutil_path]
405 url_list = [r.get_next_url() for r in revision_list] 406 url_list = [r.get_next_url() for r in revision_list]
406 args_list += [url for url in url_list if url and url is not None] 407 args_list += [url for url in url_list if url and url is not None]
407 self.api.m.python(str(name), script, args_list) 408 self.api.m.python(str(name), script, args_list)
408 409
409 def wait_for_any(self, revision_list): 410 def wait_for_any(self, revision_list):
410 """Waits for any of the revisions in the list to finish its job(s).""" 411 """Waits for any of the revisions in the list to finish its job(s)."""
411 while True: 412 while True:
412 if not revision_list or not any( 413 if not revision_list or not any(
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 return 'linux_perf_tester' 457 return 'linux_perf_tester'
457 458
458 def get_builder_bot_for_this_platform(self): 459 def get_builder_bot_for_this_platform(self):
459 # TODO: Actually look at the current platform. 460 # TODO: Actually look at the current platform.
460 return 'linux_perf_bisect_builder' 461 return 'linux_perf_bisect_builder'
461 462
462 def get_platform_gs_prefix(self): 463 def get_platform_gs_prefix(self):
463 # TODO: Actually check the current platform 464 # TODO: Actually check the current platform
464 return 'gs://chrome-perf/Linux Builder/full-build-linux_' 465 return 'gs://chrome-perf/Linux Builder/full-build-linux_'
465 466
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/bad_deps_syntax.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698