Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 104923004: [webcrypto] Implicitly set public keys to extractable. (Closed)

Created:
7 years ago by eroman
Modified:
7 years ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, padolph
Visibility:
Public.

Description

[webcrypto] Implicitly set public keys to extractable. There was consensus on this issue during TPAC, and this behavior will be called out in a forthcoming spec update. See also: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23695 BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M content/renderer/webcrypto/webcrypto_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_nss.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
7 years ago (2013-12-04 21:00:35 UTC) #1
Ryan Sleevi
lgtm
7 years ago (2013-12-05 02:17:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/104923004/1
7 years ago (2013-12-05 02:20:36 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=39533
7 years ago (2013-12-05 02:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/104923004/1
7 years ago (2013-12-05 02:39:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=39544
7 years ago (2013-12-05 02:58:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/104923004/1
7 years ago (2013-12-05 18:33:06 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-06 02:55:52 UTC) #8
Message was sent while issue was closed. 
Change committed as 239109

Powered by Google App Engine
This is Rietveld 408576698