Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: content/renderer/webcrypto/webcrypto_impl_nss.cc

Issue 104923004: [webcrypto] Implicitly set public keys to extractable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/webcrypto/webcrypto_impl.cc ('k') | content/renderer/webcrypto/webcrypto_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/webcrypto/webcrypto_impl_nss.cc
diff --git a/content/renderer/webcrypto/webcrypto_impl_nss.cc b/content/renderer/webcrypto/webcrypto_impl_nss.cc
index 42dfc334d6907bbafad0c49c234f912b25352cb4..b3cb74de42ade074be22aaa5c762f5c13ec12c18 100644
--- a/content/renderer/webcrypto/webcrypto_impl_nss.cc
+++ b/content/renderer/webcrypto/webcrypto_impl_nss.cc
@@ -755,16 +755,10 @@ bool WebCryptoImpl::GenerateKeyPairInternal(
return false;
}
- // One extractable input parameter is provided, and the Web Crypto API
- // spec at this time says it applies to both members of the key pair.
- // This is probably not correct: it makes more operational sense to have
- // extractable apply only to the private key and make the public key
- // always extractable. For now implement what the spec says and track the
- // spec bug here: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23695
*public_key = blink::WebCryptoKey::create(
new PublicKeyHandle(crypto::ScopedSECKEYPublicKey(sec_public_key)),
blink::WebCryptoKeyTypePublic,
- extractable, // probably should be 'true' always
+ true,
algorithm,
usage_mask);
*private_key = blink::WebCryptoKey::create(
« no previous file with comments | « content/renderer/webcrypto/webcrypto_impl.cc ('k') | content/renderer/webcrypto/webcrypto_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698