Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2549)

Unified Diff: content/renderer/webcrypto/webcrypto_impl.cc

Issue 104923004: [webcrypto] Implicitly set public keys to extractable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/webcrypto/webcrypto_impl_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/webcrypto/webcrypto_impl.cc
diff --git a/content/renderer/webcrypto/webcrypto_impl.cc b/content/renderer/webcrypto/webcrypto_impl.cc
index c70a42386f20bbac688bdc74a6a3dc6611c99b1d..0c4b88288028319b510d6ab6c73c201065725b1b 100644
--- a/content/renderer/webcrypto/webcrypto_impl.cc
+++ b/content/renderer/webcrypto/webcrypto_impl.cc
@@ -215,11 +215,7 @@ void WebCryptoImpl::generateKey(
DCHECK(private_key.handle());
DCHECK_EQ(algorithm.id(), public_key.algorithm().id());
DCHECK_EQ(algorithm.id(), private_key.algorithm().id());
- // TODO(padolph): The public key should probably always be extractable,
- // regardless of the input 'extractable' parameter, but that is not called
- // out in the Web Crypto API spec.
- // See https://www.w3.org/Bugs/Public/show_bug.cgi?id=23695
- DCHECK_EQ(extractable, public_key.extractable());
+ DCHECK_EQ(true, public_key.extractable());
DCHECK_EQ(extractable, private_key.extractable());
DCHECK_EQ(usage_mask, public_key.usages());
DCHECK_EQ(usage_mask, private_key.usages());
« no previous file with comments | « no previous file | content/renderer/webcrypto/webcrypto_impl_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698