Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1048863003: Handle for-in loops (Closed)

Created:
5 years, 8 months ago by vsm
Modified:
5 years, 8 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -23 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/_js_names.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/collection.js View 1 6 chunks +6 lines, -6 lines 0 comments Download
M lib/src/checker/checker.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M lib/src/checker/resolver.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M test/checker/inferred_type_test.dart View 1 1 chunk +37 lines, -2 lines 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/collection/hash_set.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/collection/queue.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/collection/splay_tree.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
5 years, 8 months ago (2015-03-30 22:59:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1048863003/diff/1/test/checker/inferred_type_test.dart File test/checker/inferred_type_test.dart (right): https://codereview.chromium.org/1048863003/diff/1/test/checker/inferred_type_test.dart#newcode619 test/checker/inferred_type_test.dart:619: for (var x in /*severe:StaticTypeError*/map) { is this ...
5 years, 8 months ago (2015-03-30 23:42:12 UTC) #3
vsm
Committed patchset #2 (id:20001) manually as c84fa91e6f2d88c9417f5415097a5d7c325462ef (presubmit successful).
5 years, 8 months ago (2015-03-31 00:22:56 UTC) #4
vsm
5 years, 8 months ago (2015-03-31 00:24:47 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1048863003/diff/1/test/checker/inferred_type_...
File test/checker/inferred_type_test.dart (right):

https://codereview.chromium.org/1048863003/diff/1/test/checker/inferred_type_...
test/checker/inferred_type_test.dart:619: for (var x in
/*severe:StaticTypeError*/map) {
On 2015/03/30 23:42:12, Siggi Cherem (dart-lang) wrote:
> is this an error because the type is not iterable? could you add a little
> comment to clarify?

Yes, a cast is needed and will fail here.  Note, I added another test case -
that one is unfortunately off.  Somehow, we're not computing that map.keys is an
Iterable<String> - at least not computing that soon enough.

Powered by Google App Engine
This is Rietveld 408576698