lib/runtime/dart/_js_names.js - Issue 1048863003: Handle for-in loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/_js_names.js

Issue 1048863003: Handle for-in loops (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/_js_names.js

diff --git a/lib/runtime/dart/_js_names.js b/lib/runtime/dart/_js_names.js

index 2152f827b68d5224e7229b57cbd646b65e64d7c0..1c6f4a7b7811e0450e8329e314f22a8853a02da1 100644

--- a/lib/runtime/dart/_js_names.js

+++ b/lib/runtime/dart/_js_names.js

@@ -26,7 +26,7 @@ var _js_names;

let getterPrefix = _foreign_helper.JS_GET_NAME('GETTER_PREFIX');

let getterPrefixLength = getterPrefix.length;

let setterPrefix = _foreign_helper.JS_GET_NAME('SETTER_PREFIX');

- for (let key of keys) {

+ for (let key of dart.as(keys, core.Iterable$(core.String))) {

let value = jsMangledNames[key];

result.set(key, value);

if (!dart.notNull(isGlobal)) {

« no previous file with comments | « lib/runtime/dart/_js_helper.js ('k') | lib/runtime/dart/collection.js » ('j') | no next file with comments »