Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: lib/runtime/dart/_isolate_helper.js

Issue 1048863003: Handle for-in loops (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_interceptors.js ('k') | lib/runtime/dart/_js_helper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_isolate_helper.js
diff --git a/lib/runtime/dart/_isolate_helper.js b/lib/runtime/dart/_isolate_helper.js
index c72ace6864a848d42b1c51161e33cf23fb8af26e..248c98ecf6974d2557df43c678b76a842cb611ff 100644
--- a/lib/runtime/dart/_isolate_helper.js
+++ b/lib/runtime/dart/_isolate_helper.js
@@ -710,14 +710,14 @@ var _isolate_helper;
dart.dinvoke(this[_scheduledControlEvents], 'clear');
}
for (let port of this.ports.values) {
- dart.dinvoke(port, '_close');
+ port._close();
}
this.ports.clear();
this.weakPorts.clear();
exports._globalState.isolates.remove(this.id);
this.errorPorts.clear();
if (this.doneHandlers != null) {
- for (let port of this.doneHandlers) {
+ for (let port of dart.as(this.doneHandlers, core.Iterable$(isolate.SendPort))) {
port.send(null);
}
this.doneHandlers = null;
« no previous file with comments | « lib/runtime/dart/_interceptors.js ('k') | lib/runtime/dart/_js_helper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698