Issue 1048583002: Revert "Implement approx-match support in image filter saveLayer() offscreen."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1048583002: Revert "Implement approx-match support in image filter saveLayer() offscreen." (Closed)

Created:
5 years, 9 months ago by Stephen White

Modified:
5 years, 9 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "Implement approx-match support in image filter saveLayer() offscreen." This reverts commit b97dafefe63ea0a1bbce8e8b209f4920983fb8b9. SkLightingImageFilter boundaries are incorrect (see GM:lighting). BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/06d3d682b4d26fb390c38ab2bb76853fd6e29be2

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -67 lines)			Patch
M	src/core/SkCanvas.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View	13 chunks	+11 lines, -35 lines	0 comments	Download
M	src/gpu/SkGpuDevice.h	View	4 chunks	+3 lines, -10 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	11 chunks	+12 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048583002/1

5 years, 9 months ago (2015-03-28 21:44:43 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-28 21:50:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/06d3d682b4d26fb390c38ab2bb76853fd6e29be2

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages