Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 104793008: Revert 240226 "[I-Spy] Add support for rebaselining expectations..." (Closed)

Created:
7 years ago by frankf
Modified:
7 years ago
Reviewers:
craigdh
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 240226 "[I-Spy] Add support for rebaselining expectations..." This breaks release-tests downstream. > [I-Spy] Add support for rebaselining expectations from the web UI. > > BUG=318865 > TEST=unittests included > NOTRY=True > > Review URL: https://codereview.chromium.org/106523003 TBR=craigdh@chromium.org BUG=329710 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -398 lines) Patch
A + trunk/src/chrome/test/functional/ispy/client/chrome_utils.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/functional/ispy/client/chrome_utils_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/test/functional/ispy/common/chrome_utils.py View 1 chunk +0 lines, -226 lines 0 comments Download
D trunk/src/chrome/test/functional/ispy/common/chrome_utils_unittest.py View 1 chunk +0 lines, -69 lines 0 comments Download
M trunk/src/chrome/test/functional/ispy/common/ispy_utils.py View 3 chunks +3 lines, -18 lines 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/app.py View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/debug_view_handler.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/gs_bucket.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/image_handler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/main_view_handler.py View 2 chunks +14 lines, -15 lines 0 comments Download
D trunk/src/chrome/test/functional/ispy/server/rebaseline_handler.py View 1 chunk +0 lines, -44 lines 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/update_mask_handler.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + trunk/src/chrome/test/functional/ispy/server/views/empty_view.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/test/functional/ispy/server/views/main_view.html View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
frankf
7 years ago (2013-12-19 01:48:20 UTC) #1
frankf
7 years ago (2013-12-19 01:48:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r241750.

Powered by Google App Engine
This is Rietveld 408576698