Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 106523003: [I-Spy] Add support for rebaselining expectations from the web UI. (Closed)

Created:
7 years ago by craigdh
Modified:
6 years, 11 months ago
Reviewers:
frankf
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, baxley
Visibility:
Public.

Description

[I-Spy] Add support for rebaselining expectations from the web UI. BUG=318865 TEST=unittests included NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243140

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Patch Set 3 : add missing dom.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -277 lines) Patch
D chrome/test/functional/ispy/client/chrome_utils.py View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/test/functional/ispy/client/chrome_utils_unittest.py View 1 chunk +0 lines, -51 lines 0 comments Download
A chrome/test/functional/ispy/client/dom.py View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A + chrome/test/functional/ispy/common/chrome_utils.py View 5 chunks +99 lines, -33 lines 0 comments Download
A chrome/test/functional/ispy/common/chrome_utils_unittest.py View 1 chunk +69 lines, -0 lines 0 comments Download
M chrome/test/functional/ispy/common/ispy_utils.py View 1 3 chunks +18 lines, -3 lines 0 comments Download
M chrome/test/functional/ispy/server/app.py View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/functional/ispy/server/debug_view_handler.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/ispy/server/gs_bucket.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/ispy/server/image_handler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/functional/ispy/server/main_view_handler.py View 2 chunks +15 lines, -14 lines 0 comments Download
A chrome/test/functional/ispy/server/rebaseline_handler.py View 1 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/test/functional/ispy/server/update_mask_handler.py View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/test/functional/ispy/server/views/empty_view.html View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/test/functional/ispy/server/views/main_view.html View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
craigdh
Corresponding downstream change will be up shortly.
7 years ago (2013-12-06 02:42:23 UTC) #1
frankf
On 2013/12/06 02:42:23, craigdh wrote: > Corresponding downstream change will be up shortly. Please provide ...
7 years ago (2013-12-07 00:23:35 UTC) #2
craigdh
On 2013/12/07 00:23:35, frankf wrote: > On 2013/12/06 02:42:23, craigdh wrote: > > Corresponding downstream ...
7 years ago (2013-12-10 19:18:24 UTC) #3
frankf
On 2013/12/10 19:18:24, craigdh wrote: > On 2013/12/07 00:23:35, frankf wrote: > > On 2013/12/06 ...
7 years ago (2013-12-11 00:34:41 UTC) #4
frankf
On 2013/12/11 00:34:41, frankf wrote: > On 2013/12/10 19:18:24, craigdh wrote: > > On 2013/12/07 ...
7 years ago (2013-12-11 00:40:19 UTC) #5
frankf
https://codereview.chromium.org/106523003/diff/1/chrome/test/functional/ispy/client/dom.py File chrome/test/functional/ispy/client/dom.py (right): https://codereview.chromium.org/106523003/diff/1/chrome/test/functional/ispy/client/dom.py#newcode17 chrome/test/functional/ispy/client/dom.py:17: return _script just return the string
7 years ago (2013-12-11 00:40:31 UTC) #6
craigdh
ptal. https://ispy.googleplex.com/?test_run=test5 The button issues were already fixed in the last patch, it just hadn't ...
7 years ago (2013-12-11 21:56:38 UTC) #7
frankf
lgtm
7 years ago (2013-12-11 22:09:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/106523003/10001
7 years ago (2013-12-12 00:09:21 UTC) #9
commit-bot: I haz the power
Change committed as 240226
7 years ago (2013-12-12 00:11:32 UTC) #10
craigdh
On 2013/12/12 00:11:32, I haz the power (commit-bot) wrote: > Change committed as 240226 Need ...
6 years, 11 months ago (2014-01-04 02:27:12 UTC) #11
frankf
lgtm
6 years, 11 months ago (2014-01-06 19:15:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/106523003/30001
6 years, 11 months ago (2014-01-06 19:29:28 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 19:31:38 UTC) #14
Message was sent while issue was closed.
Change committed as 243140

Powered by Google App Engine
This is Rietveld 408576698