Detect cygwin as Win32 for the purposes of running GN and downloading from google storage.

Detect cygwin as Win32 for the purposes of running GN and downloading from google storage.

This normalizes sys.platform so people running cygwin are treated like Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=238999

[brettw, 2013-12-05 06:11:18]

https://codereview.chromium.org/104763003/diff/1/download_from_google_storage.py
File download_from_google_storage.py (right):

https://codereview.chromium.org/104763003/diff/1/download_from_google_storage...
download_from_google_storage.py:208: if not sys.platform.startswith('win'):
I considered changing this place as well, but I can't tell what the right
behavior is. I don't think it actually matters (we might run chmod on cygwin,
but that should be OK).

[M-A Ruel, 2013-12-05 14:37:58]

lgtm

https://codereview.chromium.org/104763003/diff/1/download_from_google_storage.py
File download_from_google_storage.py (right):

https://codereview.chromium.org/104763003/diff/1/download_from_google_storage...
download_from_google_storage.py:38: if sys.platform == "cygwin":
prefer single quotes to double quotes for strings.

https://codereview.chromium.org/104763003/diff/1/download_from_google_storage...
download_from_google_storage.py:208: if not sys.platform.startswith('win'):
On 2013/12/05 06:11:19, brettw wrote:
> I considered changing this place as well, but I can't tell what the right
> behavior is. I don't think it actually matters (we might run chmod on cygwin,
> but that should be OK).

Once upon a time, someone decided to put sys.platform as 'win64' on x64 builds.
This was fixed in 2000 because it broke so many things. So 'win32' is hardcoded
for life. There's no reason to use the sys.platform.startswith('win') form
anymore, this code is either very old or very copy pasted.

From now on, use
sys.platform == 'win32'

Refs:
https://mail.python.org/pipermail/patches/2000-May/000648.html
http://hg.python.org/cpython/rev/0a3081de55a1

https://codereview.chromium.org/104763003/diff/1/gn.py
File gn.py (right):

https://codereview.chromium.org/104763003/diff/1/gn.py#newcode46
gn.py:46: if sys.platform in ['win32', 'cygwin']:
if sys.platform in ('cygwin', 'win32'):

[commit-bot: I haz the power, 2013-12-05 18:39:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/104763003/40001

[commit-bot: I haz the power, 2013-12-05 18:43:13]

Change committed as 238999