Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: download_from_google_storage.py

Issue 104763003: Detect cygwin as Win32 for the purposes of running GN and downloading from google storage. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: download_from_google_storage.py
===================================================================
--- download_from_google_storage.py (revision 238993)
+++ download_from_google_storage.py (working copy)
@@ -32,6 +32,14 @@
pass
+def GetNormalizedPlatform():
+ """Returns the result of sys.platform accounting for cygwin.
+ Under cygwin, this will always return "win32" like the native Python."""
+ if sys.platform == 'cygwin':
+ return 'win32'
+ return sys.platform
+
+
# Common utilities
class Gsutil(object):
"""Call gsutil with some predefined settings. This is a convenience object,
@@ -197,7 +205,7 @@
# TODO(hinoka): It is supposedly faster to use "gsutil stat" but that
# doesn't appear to be supported by the gsutil currently in our tree. When
# we update, this code should use that instead of "gsutil ls -L".
- if not sys.platform.startswith('win'):
+ if sys.platform != 'win32':
code, out, _ = gsutil.check_call('ls', '-L', file_url)
if code != 0:
out_q.put('%d> %s' % (thread_num, err))
« no previous file with comments | « no previous file | gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698