Issue 1047493003: Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems foun…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1047493003: Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems foun… (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton

Modified:
5 years, 8 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems found by clang_tidy. Merge internal change: 89724433 R=rtenneti@chromium.org

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -11 lines)			Patch
M	net/quic/quic_connection_test.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	net/quic/quic_framer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_framer.cc	View	2 chunks	+5 lines, -1 line	1 comment	Download
M	net/quic/quic_protocol.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

5 years, 9 months ago (2015-03-28 13:56:56 UTC) #2

lgtm

https://codereview.chromium.org/1047493003/diff/1/net/quic/quic_framer.cc
File net/quic/quic_framer.cc (right):

https://codereview.chromium.org/1047493003/diff/1/net/quic/quic_framer.cc#new...
net/quic/quic_framer.cc:752: << ", tag = '" << QuicUtils::TagToString(tag) <<
"'";
nit: indentation on line 752.

Expand Messages | Collapse Messages