Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: net/quic/quic_framer.h

Issue 1047493003: Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems foun… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_framer.h
diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h
index 7b1a55ec13887f18ec8d53f1a0c3bd2ee60035b0..a3cc5fa3fdf3ce25aa0953c8f48f970acbbd69f3 100644
--- a/net/quic/quic_framer.h
+++ b/net/quic/quic_framer.h
@@ -459,6 +459,10 @@ class NET_EXPORT_PRIVATE QuicFramer {
// The Append* methods attempt to write the provided header or frame using the
// |writer|, and return true if successful.
+
+ // If header.public_header.version_flag is set, the version in the
+ // packet will be set -- but it will be set from quic_version_ not
+ // header.public_header.versions.
bool AppendPacketHeader(const QuicPacketHeader& header,
QuicDataWriter* writer);
bool AppendTypeByte(const QuicFrame& frame,

Powered by Google App Engine
This is Rietveld 408576698