net/quic/quic_framer.cc - Issue 1047493003: Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems foun…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer.cc

Issue 1047493003: Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems foun… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer.cc

diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc

index 545bfa5a9c63bfb14ae90aeebe82285f58d75e65..833791096b91f8d7a1c6a60040230be5525e45b0 100644

--- a/net/quic/quic_framer.cc

+++ b/net/quic/quic_framer.cc

@@ -15,6 +15,7 @@

#include "net/quic/quic_data_writer.h"

#include "net/quic/quic_flags.h"

#include "net/quic/quic_socket_address_coder.h"

+#include "net/quic/quic_utils.h"

using base::StringPiece;

using std::map;

@@ -745,7 +746,10 @@ bool QuicFramer::AppendPacketHeader(const QuicPacketHeader& header,

if (header.public_header.version_flag) {

DCHECK_EQ(Perspective::IS_CLIENT, perspective_);

- writer->WriteUInt32(QuicVersionToQuicTag(quic_version_));

+ QuicTag tag = QuicVersionToQuicTag(quic_version_);

+ writer->WriteUInt32(tag);

+ DVLOG(1) << "version = " << quic_version_

+ << ", tag = '" << QuicUtils::TagToString(tag) << "'";

ramant (doing other things) 2015/03/28 13:56:56 nit: indentation on line 752.

}

if (!AppendPacketSequenceNumber(header.public_header.sequence_number_length,

« no previous file with comments | « net/quic/quic_framer.h ('k') | net/quic/quic_protocol.cc » ('j') | no next file with comments »