Address late comments from CL 50313007.

Address late comments from CLs 50313007 and 27524003.

[ngeoffray, 2013-12-09 15:34:05]

LGTM

https://codereview.chromium.org/104723004/diff/1/dart/sdk/lib/_internal/compi...
File
dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
(right):

https://codereview.chromium.org/104723004/diff/1/dart/sdk/lib/_internal/compi...
dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart:570:
currentClass = currentClass.currentClass;
currentClass -> superclass ? :-)

[ahe, 2013-12-09 16:15:02]

PTAL, added your comments from  CL 27524003 as well.

[ngeoffray, 2013-12-09 16:22:03]

Still LGTM

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/c...
File
dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/c...
dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:183:
Set<Selector> selectors = member.isInstanceMember()
My comment was to put the initialization of selectors inside the if:

Set<Selector> selectors;
if (member.isInstanceMember()) {
  selectors = ...
  ...
} else {
  selectors == callSelectorsAsNamed();
  ...
}

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/l...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/l...
dart/sdk/lib/_internal/lib/js_mirrors.dart:1635: // between method that could be
torn off and a constructor (the bound
between *a* method

[ahe, 2013-12-09 17:16:01]

https://codereview.chromium.org/104723004/diff/1/dart/sdk/lib/_internal/compi...
File
dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart
(right):

https://codereview.chromium.org/104723004/diff/1/dart/sdk/lib/_internal/compi...
dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart:570:
currentClass = currentClass.currentClass;
On 2013/12/09 15:34:05, ngeoffray wrote:
> currentClass -> superclass ? :-)

Done.

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/c...
File
dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/c...
dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:183:
Set<Selector> selectors = member.isInstanceMember()
On 2013/12/09 16:22:03, ngeoffray wrote:
> My comment was to put the initialization of selectors inside the if:
> 
> Set<Selector> selectors;
> if (member.isInstanceMember()) {
>   selectors = ...
>   ...
> } else {
>   selectors == callSelectorsAsNamed();
>   ...
> }

But that's not what the code looks like.

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/l...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/l...
dart/sdk/lib/_internal/lib/js_mirrors.dart:1635: // between method that could be
torn off and a constructor (the bound
On 2013/12/09 16:22:03, ngeoffray wrote:
> between *a* method

Done.

[ngeoffray, 2013-12-09 17:19:59]

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/c...
File
dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/104723004/diff/10001/dart/sdk/lib/_internal/c...
dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:183:
Set<Selector> selectors = member.isInstanceMember()
On 2013/12/09 17:16:01, ahe wrote:
> On 2013/12/09 16:22:03, ngeoffray wrote:
> > My comment was to put the initialization of selectors inside the if:
> > 
> > Set<Selector> selectors;
> > if (member.isInstanceMember()) {
> >   selectors = ...
> >   ...
> > } else {
> >   selectors == callSelectorsAsNamed();
> >   ...
> > }
> 
> But that's not what the code looks like.

Oh I see. So it's the null check that bothered me. I guess we both agree that
being able to write:

Set<Selector> selectors = member.isInstanceMember()
  ? compiler.codegenWorld.invokedNames[member.name]
  : new Set<Selector>();
selectors = selectors.union(callSelectorsAsNamed());

But nulls are just annoying.