Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: dart/sdk/lib/_internal/lib/js_mirrors.dart

Issue 104723004: Address late comments from CL 50313007. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Another typo Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/lib/js_helper.dart ('k') | dart/tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/dart/sdk/lib/_internal/lib/js_mirrors.dart b/dart/sdk/lib/_internal/lib/js_mirrors.dart
index ba809de98874a716724c141d3153732464e8504d..cb4897515bf99a2eaedaacf7ac7245b686bb4ace 100644
--- a/dart/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/dart/sdk/lib/_internal/lib/js_mirrors.dart
@@ -1631,7 +1631,10 @@ class JsClosureMirror extends JsInstanceMirror implements ClosureMirror {
MethodMirror get function {
String cacheName = Primitives.mirrorFunctionCacheName;
JsMethodMirror cachedFunction;
- // TODO(ahe): Restore caching.
+ // TODO(ahe): Restore caching. We used to have a one-to-one correspondence
+ // between a method that could be torn off and a constructor (the bound
+ // closure classes). But now all tear-offs share the same constructor (a
+ // class called BoundClosure in js_helper.dart).
//= JS('JsMethodMirror|Null', r'#.constructor[#]', reflectee, cacheName);
if (cachedFunction != null) return cachedFunction;
disableTreeShaking();
@@ -1769,6 +1772,7 @@ class JsMethodMirror extends JsDeclarationMirror implements MethodMirror {
var functionType = info.functionType;
var type;
if (functionType is int) {
+ // A reference to a type variable in init.metadata.
type = new JsFunctionTypeMirror(info.computeFunctionRti(null), this);
assert(_parameterCount == type.parameters.length);
} else if (isTopLevel) {
« no previous file with comments | « dart/sdk/lib/_internal/lib/js_helper.dart ('k') | dart/tests/language/language_dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698