dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart - Issue 104723004: Address late comments from CL 50313007.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

Issue 104723004: Address late comments from CL 50313007. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Another typo Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

index 85570b2841f16fff2b813b6a84ed793cd8b5d5c7..d8bb4aadef2cfb887f9e896a1f46b802689af1ef 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

@@ -44,7 +44,7 @@ class MetadataEmitter extends CodeEmitterHelper {

List<int> reifyDefaultArguments(FunctionElement function) {

FunctionSignature signature = function.computeSignature(compiler);

- if (signature.optionalParameterCount == 0) return const [];

+ if (signature.optionalParameterCount == 0) return const <int>[];

List<int> defaultValues = <int>[];

for (Element element in signature.orderedOptionalParameters) {

Constant value =